GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Fix capitalization of Unix in multiprocessing documentation by hawkinsw · Pull Request #96913 · python/cpython

Conversation

@hawkinsw

@hawkinsw hawkinsw commented Sep 18, 2022

Copy link
Copy Markdown
Contributor

Fix capitalization of Unix in multiprocessing documentation

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Sep 18, 2022
kumiDa
kumiDa approved these changes Sep 18, 2022
View reviewed changes

@kumiDa kumiDa left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation.
The change lgtm.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Sep 18, 2022
@hawkinsw

hawkinsw commented Sep 18, 2022

Copy link
Copy Markdown
Contributor Author

I was able to verify this change that corrects the deviation from the convention of addressing Unix in the documentation. The change lgtm.

Thank you @rahul-kumi!!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra JelleZijlstra added skip issue needs backport to 3.10 needs backport to 3.11 only security fixes labels Sep 30, 2022
@JelleZijlstra

JelleZijlstra commented Sep 30, 2022

Copy link
Copy Markdown
Member

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions.
library/test.rst:   Bind a unix socket, raising :exc:`unittest.SkipTest` if

And probably also these:

library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra JelleZijlstra self-assigned this Sep 30, 2022
@hawkinsw
hawkinsw force-pushed the typo_fix branch from f9227f3 to 9cd713e Compare September 30, 2022 19:22
@hawkinsw
hawkinsw requested a review from a team as a code owner September 30, 2022 19:22
@hawkinsw
Fix capitalization of Unix in documentation
9ea3670
Change 'unix' to 'Unix' throughout documentation.
@hawkinsw
hawkinsw force-pushed the typo_fix branch from 9cd713e to 9ea3670 Compare September 30, 2022 19:23
@hawkinsw

hawkinsw commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

Thanks! Would you mind also changing these:

library/os.path.rst:Unlike a unix shell, Python does not do any *automatic* path expansions.
library/test.rst:   Bind a unix socket, raising :exc:`unittest.SkipTest` if

And probably also these:

library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.compat32-message.rst:      required by the unix mbox format.  For more flexibility, instantiate a
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox
library/email.generator.rst:   *mangle_from_* is intended for use when messages are stored in unix mbox

All updated! I have changed the title of the commit to better reflect that the change is a little wider than initially suggested. I also rebased against master to make it smoother! I hope that it helps! Thanks for the review!

Will

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303
kumaraditya303 approved these changes Oct 1, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit bd7d0e8 into python:main Oct 1, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 1, 2022
@miss-islington

miss-islington commented Oct 1, 2022

Copy link
Copy Markdown
Contributor

Thanks @hawkinsw for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Oct 1, 2022

Copy link
Copy Markdown

GH-97711 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 1, 2022
@bedevere-bot

bedevere-bot commented Oct 1, 2022

Copy link
Copy Markdown

GH-97712 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 1, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
@hawkinsw @miss-islington
Fix capitalization of Unix in documentation (pythonGH-96913)
aa2387a
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 1, 2022
@hawkinsw @miss-islington
Fix capitalization of Unix in documentation (pythonGH-96913)
5197b35
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <[email protected]>
miss-islington added a commit that referenced this pull request Oct 1, 2022
@miss-islington @hawkinsw
Fix capitalization of Unix in documentation (GH-96913)
35a394c
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <[email protected]>
miss-islington added a commit that referenced this pull request Oct 1, 2022
@miss-islington @hawkinsw
Fix capitalization of Unix in documentation (GH-96913)
748b2b7
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <[email protected]>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@hawkinsw @serhiy-storchaka
Fix capitalization of Unix in documentation (python#96913)
0bb7e71
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @hawkinsw @pablogsal
Fix capitalization of Unix in documentation (GH-96913)
b8afd5f
(cherry picked from commit bd7d0e8)

Co-authored-by: Will Hawkins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
+1 more reviewer
@kumiDa kumiDa kumiDa approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@hawkinsw @JelleZijlstra @miss-islington @bedevere-bot @kumiDa @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.