GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-96975: Skip incomplete frames in `PyEval_GetFrame` by brandtbucher · Pull Request #97003 · python/cpython

Conversation

@brandtbucher

@brandtbucher brandtbucher commented Sep 21, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: PyEval_GetFrame crashes when it returns incomplete frames #96975

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
brandtbucher added 3 commits September 21, 2022 15:54
@brandtbucher
Add failing regression test
5e1af12
@brandtbucher
Skip over incomplete frames in PyEval_GetFrame
8eba6ce
@brandtbucher
blurb add
3ca6725
@brandtbucher brandtbucher added interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels Sep 21, 2022
@brandtbucher
brandtbucher requested review from ericsnowcurrently and pablogsal September 21, 2022 23:11
@brandtbucher brandtbucher self-assigned this Sep 21, 2022
@brandtbucher
brandtbucher requested a review from markshannon as a code owner September 21, 2022 23:11
@bedevere-bot bedevere-bot added the awaiting core review label Sep 21, 2022
ericsnowcurrently
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

I've left a few minor comments but leave it to you to decide.

(I'm approving under the assumption you will get it right before merging.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Programs/_testembed.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Programs/_testembed.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Programs/_testembed.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/ceval.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 22, 2022
@brandtbucher
Feedback from code review
f46f56d
ericsnowcurrently
ericsnowcurrently approved these changes Sep 22, 2022
View reviewed changes

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brandtbucher
brandtbucher merged commit 8fd2c3b into python:main Sep 22, 2022
@miss-islington

miss-islington commented Sep 22, 2022

Copy link
Copy Markdown
Contributor

Thanks @brandtbucher for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 22, 2022
@bedevere-bot

bedevere-bot commented Sep 22, 2022

Copy link
Copy Markdown

GH-97018 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 22, 2022
@brandtbucher @miss-islington
pythonGH-96975: Skip incomplete frames in PyEval_GetFrame (pythonGH-9…
3f60d68 
…7003)

(cherry picked from commit 8fd2c3b)

Co-authored-by: Brandt Bucher <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently ericsnowcurrently approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@brandtbucher brandtbucher

Labels

interpreter-core (Objects, Python, Grammar, and Parser dirs) type-crash A hard crash of the interpreter, possibly with a core dump

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@brandtbucher @miss-islington @bedevere-bot @ericsnowcurrently
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.