GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-79856: IDLE - separate config_key window and frame (GH-11427) by miss-islington · Pull Request #97684 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy [email protected]
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella [email protected]

  • Issue: IDLE: Refactor config_key module. #79856

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csabella @miss-islington
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
e14c481 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <[email protected]>
@miss-islington
miss-islington requested a review from terryjreedy as a code owner September 30, 2022 16:44
@bedevere-bot bedevere-bot mentioned this pull request Sep 30, 2022
gh-79856: IDLE - separate config_key window and frame #11427
Merged
@bedevere-bot bedevere-bot added skip news awaiting review labels Sep 30, 2022
terryjreedy
terryjreedy approved these changes Sep 30, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Sep 30, 2022
@miss-islington

miss-islington commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 30, 2022

Copy link
Copy Markdown
Contributor Author

Status check is done, and it's a success ✅.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit b61a51a into python:3.10 Sep 30, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 30, 2022
@miss-islington
miss-islington deleted the backport-1cc308d-3.10 branch September 30, 2022 17:27
@terryjreedy terryjreedy changed the title [3.10] bpo-35675: IDLE - separate config_key window and frame (GH-11427) [3.10] gh-79856: IDLE - separate config_key window and frame (GH-11427) Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @terryjreedy @bedevere-bot @csabella
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.