GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-79856: IDLE - separate config_key window and frame by csabella · Pull Request #11427 · python/cpython

Conversation

@csabella

@csabella csabella commented Jan 3, 2019 •
edited by terryjreedy
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Split dialog class into a Window class and Frame class and adjust tests to match.

  • Issue: IDLE: Refactor config_key module. #79856

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csabella
csabella requested a review from terryjreedy as a code owner January 3, 2019 23:55
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jan 3, 2019
@bedevere-bot bedevere-bot added the awaiting review label Jan 3, 2019
@terryjreedy terryjreedy changed the title bpo-35598: IDLE: Refactor configkey.py window and frame class bpo-35675: IDLE config_key - separate window and frame classes Jan 7, 2019
auvipy
auvipy suggested changes Jun 2, 2019
View reviewed changes

@auvipy auvipy left a comment

Copy link
Copy Markdown

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Jun 2, 2019
@csabella
csabella force-pushed the configkey branch from c368753 to 4f40259 Compare January 19, 2020 15:15
@csabella
bpo-35598: IDLE: Refactor window and frame class
43595c9
@csabella
csabella force-pushed the configkey branch from 4f40259 to 43595c9 Compare June 13, 2020 21:27
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
iritkatriel
iritkatriel previously requested changes Sep 30, 2022
View reviewed changes

@iritkatriel iritkatriel left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be rebased.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the awaiting changes label Sep 30, 2022
@iritkatriel iritkatriel added the pending The issue will be closed if no feedback is provided label Sep 30, 2022
@terryjreedy terryjreedy changed the title bpo-35675: IDLE config_key - separate window and frame classes bpo-35675: IDLE config_key - separate window and frame Sep 30, 2022
@terryjreedy
Merge branch 'main' into configkey
531ba77
@terryjreedy terryjreedy removed awaiting changes pending The issue will be closed if no feedback is provided labels Sep 30, 2022
@terryjreedy terryjreedy self-assigned this Sep 30, 2022
@terryjreedy terryjreedy added skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Sep 30, 2022
@terryjreedy terryjreedy changed the title bpo-35675: IDLE config_key - separate window and frame bpo-35675: IDLE - separate config_key window and frame Sep 30, 2022
@terryjreedy
terryjreedy dismissed iritkatriel’s stale review September 30, 2022 16:44

Conflick resolved

@terryjreedy
terryjreedy merged commit 1cc308d into python:main Sep 30, 2022
@miss-islington

miss-islington commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97683 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97684 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@csabella @miss-islington
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
d28ac0d 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@csabella @miss-islington
bpo-35675: IDLE - separate config_key window and frame (pythonGH-11427)
e14c481 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @csabella
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
ab2f1a6 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @csabella
bpo-35675: IDLE - separate config_key window and frame (GH-11427)
b61a51a 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
(cherry picked from commit 1cc308d)

Co-authored-by: Cheryl Sabella <[email protected]>
@terryjreedy terryjreedy changed the title bpo-35675: IDLE - separate config_key window and frame gh-79856: IDLE - separate config_key window and frame Sep 30, 2022
@terryjreedy terryjreedy mentioned this pull request Sep 30, 2022
IDLE: Refactor config_key module. #79856
Closed
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@csabella @terryjreedy @serhiy-storchaka
bpo-35675: IDLE - separate config_key window and frame (python#11427)
8fd0e86 
bpo-35598: IDLE: Refactor window and frame class

Co-authored-by: Terry Jan Reedy <[email protected]>
mpage added a commit to mpage/cpython that referenced this pull request Feb 16, 2024
@mpage
Merge branch 'pythongh-114271-_thread-ThreadHandle' into pythongh-11427…
012ea77 
…-cherry-pick-ThreadHandle
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner
+1 more reviewer
@auvipy auvipy auvipy requested changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@terryjreedy terryjreedy

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

8 participants

@csabella @bedevere-bot @miss-islington @iritkatriel @auvipy @the-knights-who-say-ni @terryjreedy @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.