GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87597: Document TimeoutExpired.stdout & .stderr types. by gpshead · Pull Request #97685 · python/cpython

Conversation

@gpshead

@gpshead gpshead commented Sep 30, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This documents the behavior that has always been the case since timeout support was introduced in Python 3.3.

  • Issue: Subprocess timeout causes output to be returned as bytes in text mode #87597

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gpshead
pythongh-87597: Document TimeoutExpired.stdout & .stderr types.
83a8a06 
This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
@gpshead gpshead added docs Documentation in the Doc dir needs backport to 3.9 needs backport to 3.11 only security fixes labels Sep 30, 2022
@gpshead gpshead self-assigned this Sep 30, 2022
@bedevere-bot bedevere-bot added awaiting core review skip news labels Sep 30, 2022
@gpshead
gpshead marked this pull request as ready for review September 30, 2022 17:35
@gpshead
slight rewording clarification.
35dcb7d 
That is is None even when people ask to capture output but the process
generated no output is a long standing API wart.
@gpshead
gpshead merged commit b05dd79 into python:main Sep 30, 2022
@miss-islington

miss-islington commented Sep 30, 2022

Copy link
Copy Markdown
Contributor

Thanks @gpshead for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 30, 2022
@gpshead
gpshead deleted the docs/subprocess-timeoutexpired-bytes branch September 30, 2022 17:45
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97686 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Sep 30, 2022
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97687 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@gpshead @miss-islington
pythongh-87597: Document TimeoutExpired.stdout & .stderr types (pytho…
39e2304 
…nGH-97685)

This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@gpshead @miss-islington
pythongh-87597: Document TimeoutExpired.stdout & .stderr types (pytho…
7bc3ec6 
…nGH-97685)

This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 30, 2022

Copy link
Copy Markdown

GH-97688 is a backport of this pull request to the 3.9 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Sep 30, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 30, 2022
@gpshead @miss-islington
pythongh-87597: Document TimeoutExpired.stdout & .stderr types (pytho…
189ba73 
…nGH-97685)

This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @gpshead
gh-87597: Document TimeoutExpired.stdout & .stderr types (GH-97685)
6d7dbcc 
This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
miss-islington added a commit that referenced this pull request Sep 30, 2022
@miss-islington @gpshead
gh-87597: Document TimeoutExpired.stdout & .stderr types (GH-97685)
cdc01ea 
This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
serhiy-storchaka pushed a commit to serhiy-storchaka/cpython that referenced this pull request Oct 2, 2022
@gpshead @serhiy-storchaka
pythongh-87597: Document TimeoutExpired.stdout & .stderr types (pytho…
d1d6b31 
…n#97685)

This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
ambv pushed a commit that referenced this pull request Oct 4, 2022
@miss-islington @gpshead
[3.9] gh-87597: Document TimeoutExpired.stdout & .stderr types (GH-97685
94dbdbb 
) (GH-97688)

This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
hauntsaninja added a commit to hauntsaninja/typeshed that referenced this pull request Oct 12, 2022
@hauntsaninja
subprocess: use narrower types for TimeoutExpired.std*
90e3d38 
See python/cpython#97685

Thinking we'll go off of mypy_primer to decide if the union type here is
acceptable or not. I'd like us to be able to type this, since the values
being bytes can be surprising if you pass text=True
@hauntsaninja hauntsaninja mentioned this pull request Oct 12, 2022
subprocess: use narrower types for TimeoutExpired.std* python/typeshed#8886
Merged
hauntsaninja added a commit to python/typeshed that referenced this pull request Oct 12, 2022
@hauntsaninja
subprocess: use narrower types for TimeoutExpired.std* (#8886)
33e1a34 
See python/cpython#97685

The union type should be acceptable given python/cpython#87597 (comment). In general I'd like us to be able to type this, since these being bytes can be surprising if you pass text=True, but we'll see what mypy_primer says
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @gpshead @pablogsal
gh-87597: Document TimeoutExpired.stdout & .stderr types (GH-97685)
c12c993 
This documents the behavior that has always been the case since timeout
support was introduced in Python 3.3.
(cherry picked from commit b05dd79)

Co-authored-by: Gregory P. Smith <[email protected]>
@Paro131

Paro131 commented Dec 3, 2022

Copy link
Copy Markdown

Thx
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland erlend-aasland mentioned this pull request Jan 5, 2024
Subprocess timeout causes output to be returned as bytes in text mode #87597
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gpshead gpshead

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@gpshead @miss-islington @bedevere-bot @Paro131
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.