GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: Move py.exe to appropriate What's New section & refine text by CAM-Gerlach · Pull Request #97718 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #95913

Discussion of the improvements to the py.exe Windows launcher was mistakenly added to the "New Features Related to Type Hints" section of the What's New in #96595 , which clearly doesn't seem to be the right place. I moved it to what seemed to be the most appropriate existing section, New Features (since there wasn't a section specific to ancillary utilities or Windows-specific changes, and I didn't want to introduce a whole new section just for it especially at this late hour, and because that was the most likely section it was intended to go under).

In addition, I made some minor refinements to the text/syntax consistent with the other What's New changes, including:

  • Be more explicit to clarify what the legacy version arg components represent, as I was initially somewhat confused (especially on -ZZ)
  • Add a ref target label and using a literal for py.exe, consistent with general convention and its specific usage elsewhere
  • Apply other minor grammar, clarity and readability fixes
  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CAM-Gerlach added 4 commits October 1, 2022 20:13
@CAM-Gerlach
Move Windows py.exe improvements from Typing section to New Features
aea1a8b
@CAM-Gerlach
Add ref target label and use literal for py.exe
80538dd
@CAM-Gerlach
Be clearer/explict about what legacy version arg components reprisent
55c2d5b
@CAM-Gerlach
Apply other minor clarity and textual fixes to py.exe launcher text
cd71489
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 2, 2022
@CAM-Gerlach
CAM-Gerlach requested review from ezio-melotti, pablogsal and zooba October 2, 2022 04:52
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes OS-windows labels Oct 2, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 2, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
ezio-melotti
ezio-melotti reviewed Oct 3, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Oct 4, 2022

Copy link
Copy Markdown
Member

I approve whatever you decide to do here. No strong opinions
ezio-melotti reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@CAM-Gerlach @ezio-melotti
Refine phrasing of legacy sentence of py.exe desc
ec51650 
Co-authored-by: Ezio Melotti <[email protected]>
@CAM-Gerlach
CAM-Gerlach requested a review from ezio-melotti October 4, 2022 22:26
ezio-melotti
ezio-melotti approved these changes Oct 4, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 4, 2022
@ezio-melotti
ezio-melotti merged commit 9859581 into python:main Oct 4, 2022
@miss-islington

miss-islington commented Oct 4, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @ezio-melotti for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed awaiting merge needs backport to 3.11 only security fixes labels Oct 4, 2022
@bedevere-bot

bedevere-bot commented Oct 4, 2022

Copy link
Copy Markdown

GH-97853 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 4, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Move py.exe to appropriate What's New section & refin…
49314d9 
…e text (pythonGH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Oct 4, 2022
@miss-islington @CAM-Gerlach
gh-95913: Move py.exe to appropriate What's New section & refine text (…
a685cc0 
…GH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <[email protected]>
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@CAM-Gerlach @ezio-melotti @mpage
pythongh-95913: Move py.exe to appropriate What's New section & refin…
937cc6d 
…e text (python#97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Ezio Melotti <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @CAM-Gerlach @pablogsal
gh-95913: Move py.exe to appropriate What's New section & refine text (…
028e7d4 
…GH-97718)

* Move Windows py.exe improvements from Typing section to New Features

* Add ref target label and use literal for py.exe

* Be clearer/explict about what legacy version arg components reprisent

* Apply other minor clarity and textual fixes to py.exe launcher text

* Refine phrasing of legacy sentence of py.exe desc

Co-authored-by: Ezio Melotti <[email protected]>

Co-authored-by: Ezio Melotti <[email protected]>
(cherry picked from commit 9859581)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ezio-melotti ezio-melotti ezio-melotti approved these changes
@zooba zooba Awaiting requested review from zooba
@pablogsal pablogsal Awaiting requested review from pablogsal

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir OS-windows skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@CAM-Gerlach @zooba @miss-islington @bedevere-bot @ezio-melotti
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.