GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Add more syslog tests by serhiy-storchaka · Pull Request #97953 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 6, 2022

Copy link
Copy Markdown
Member
  1. It tries to cover changes in syslog issues #95041 by tests. Unfortunately it does not work for all changes, some of them cannot be tested in principle, but I hope that it can prevent similar future regressions.
  2. It includes extended version of tests proposed in gh-95011: Migrate syslog module to Argument Clinic #95012. They are worth to be backported.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
noamcohen97 reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@serhiy-storchaka
Add more syslog tests
8daeb2e
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip issue skip news needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 6, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@serhiy-storchaka serhiy-storchaka mentioned this pull request Oct 6, 2022
gh-95011: Migrate syslog module to Argument Clinic #95012
Merged
JelleZijlstra
JelleZijlstra approved these changes Oct 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 7, 2022
@serhiy-storchaka
serhiy-storchaka merged commit cae7d1d into python:main Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka deleted the syslog-tests branch October 7, 2022 17:17
@miss-islington miss-islington assigned serhiy-storchaka Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 and removed needs backport to 3.10 labels Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 8, 2022
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Oct 8, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cae7d1d7a713f8267daf5e4f2fff5cb1dad02c7c 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 8, 2022
@bedevere-bot

bedevere-bot commented Oct 8, 2022

Copy link
Copy Markdown

GH-98096 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.11] Add more syslog tests (pythonGH-97953).
2090dc5 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.11] Add more syslog tests (GH-97953). (GH-98096)
f6e50b8 
(cherry picked from commit cae7d1d)
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 label Oct 8, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (pythonGH-97953).
f382c43 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 8, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (pythonGH-97953).
5867ece 
(cherry picked from commit cae7d1d)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Oct 9, 2022
@serhiy-storchaka
[3.10] Add more syslog tests (GH-97953). (GH-98101)
4d7d91f 
(cherry picked from commit cae7d1d)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@serhiy-storchaka @mpage
Add more syslog tests (pythonGH-97953)
bdf0373
@hauntsaninja hauntsaninja mentioned this pull request Oct 12, 2022
syslog issues #95041
Closed
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.