GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97669: Move difflib examples to Doc/includes/ by vstinner · Pull Request #97964 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Remove diff.py and ndiff.py scripts of Tools/scripts/: move them to Doc/includes/.

  • diff.py and ndiff.py files are no longer executable. Remove also their shebang ("#!/usr/bin/env python3").
  • Remove the -profile command from ndiff.py to simply the code.
  • Remove ndiff.py copyright and history command. The Python documentation examples are distributed under the "Zero Clause BSD License".
  • Issue: Remove outdated Tools/scripts/ example scripts #97669

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@vstinner

vstinner commented Oct 6, 2022

Copy link
Copy Markdown
Member Author

I'm not sure if it's worth it to keep the ndiff.py example. Maybe we can just remove it? IMO ndiff.py is a little bit complicated to show it as an example.

@JulienPalard: Would you mind to have a look? Who else should I ask for a doc review?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner mentioned this pull request Oct 6, 2022
Remove outdated Tools/scripts/ example scripts #97669
Closed
@JulienPalard

JulienPalard commented Oct 7, 2022

Copy link
Copy Markdown
Member

@vstinner Those issues has been fixed (both sphinx-lint side for the false positives, and cpython side for the true positives), can you rebase?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
gh-97669: Move difflib examples to Doc/includes/
564c50e 
Remove diff.py and ndiff.py scripts of Tools/scripts/: move them to
Doc/includes/.

* diff.py and ndiff.py files are no longer executable. Remove also
  their shebang ("#!/usr/bin/env python3").
* Remove the -profile command from ndiff.py to simply the code.
* Remove ndiff.py copyright and history command. The Python
  documentation examples are distributed under the "Zero Clause BSD
  License".
@vstinner

vstinner commented Oct 7, 2022

Copy link
Copy Markdown
Member Author

I rebased my PR.

I will not add a dedicated NEWS entry, since I already documented the removal in a previous PR: https://docs.python.org/dev/whatsnew/3.12.html#demos-and-tools
JulienPalard reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner vstinner added the skip news label Oct 7, 2022
@ambv
ambv merged commit 002252c into python:main Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 7, 2022
@vstinner
vstinner deleted the difflib_examples branch October 8, 2022 09:47
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@vstinner @mpage
pythongh-97669: Move difflib examples to Doc/includes/ (python#97964)
97ae2e9 
Remove diff.py and ndiff.py scripts of Tools/scripts/: move them to
Doc/includes/.

* diff.py and ndiff.py files are no longer executable. Remove also
  their shebang ("#!/usr/bin/env python3").
* Remove the -profile command from ndiff.py to simply the code.
* Remove ndiff.py copyright and history command. The Python
  documentation examples are distributed under the "Zero Clause BSD
  License".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @JulienPalard @ambv @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.