GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

GeezerVison is showing github.com — bpo-29556: Remove unused #include <langinfo.h> by yan12125 · Pull Request #98 · python/cpython

Conversation

yan12125 commented Feb 14, 2017

Copy link

Copy Markdown

This #include is added in b744ba1 (issue8610) and later the use of CODESET is removed in d64e8a7 (issue9642).

Found this in investigating issue29436

This is a minor fix but my first patch on Github. Hope everything works :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

the-knights-who-say-ni added the CLA signed label

vstinner approved these changes

View reviewed changes

yan12125 commented Feb 14, 2017

Copy link

Copy Markdown

Author

Sorry, but seems there are more. Please give me some time to check them one by one.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.


          bpo-29556: Remove unused #include <langinfo.h>

f13deaa

bltinmodule.c: Added in b744ba1 and no longer necessary since d64e8a7
posixmodule.c: Added in d1cd4d4 and no longer necessary since efb00c0
pythonrun.c:   Added in 73d538b and no longer necessary since d600951
sysmodule.c:   Added in 5467d4c and no longer necessary since a2c17c5

yan12125 changed the title ~~bpo-29556: Remove an unused #include from bltinmodule.c~~ bpo-29556: Remove unused #include <langinfo.h>

vstinner commented Feb 15, 2017

Copy link

Copy Markdown

Member

Still LGTM. Thanks for the commit numbers, it helped me to validate your change.

yan12125 reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner merged commit 72e81d0 into python:master

yan12125 deleted the remove-unused-include branch

February 16, 2017 09:44

akruis pushed a commit to akruis/cpython that referenced this pull request


          Stackless issue python#98: Prevent an unlikely NULL-pointer access in…

f2607c9

… safe_pickle.c pickle_callback().

The bug is very old and might affect multiprocessing. The change fixes the bug and adds
a test case.

https://bitbucket.org/stackless-dev/stackless/issues/98
(grafted from 7cd2a4e39aa757427ccbf176ef7a0cd6f8f1514e)

akruis pushed a commit to akruis/cpython that referenced this pull request


          merge 3.4-slp (Stackless python#96, python#98)

44c7230

akruis pushed a commit to akruis/cpython that referenced this pull request


          Stackless issue python#98: Skip the test case, if stackless is compil…

ae3b80b

…ed without threads.

The test case needs threding.

https://bitbucket.org/stackless-dev/stackless/issues/98
(grafted from 16c5769adf70810e23d480a51dddc60f34384251)

akruis pushed a commit to akruis/cpython that referenced this pull request


          merge 3.3-slp (Stackless python#98)

048c660

akruis pushed a commit to akruis/cpython that referenced this pull request


          merge 3.4-slp (Stackless python#98)

01d457e

jaraco pushed a commit that referenced this pull request


          Update cherry_picker from 1.1.1 to 1.2.0 (GH-98)

507bb0d

jaraco added a commit to jaraco/cpython that referenced this pull request


          Add codecov token to the repository to enable merge requests not to f…

3e6c99e

…ail. Closes python#98.

gvanrossum mentioned this pull request

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

ngoldbaum mentioned this pull request

Crash running PyO3 tests with --test-threads=1000 #124375

Closed

This was referenced Feb 11, 2025

segmentfault when pip installing setuptools #129992

Closed

segmentfault when pip installing setuptools #129993

Closed

ambv referenced this pull request in ambv/cpython


          Merge pull request #98 from ivonastojanovic/external_debugger_windows…

…_support

External debugger Windows support

sergey-miryanov mentioned this pull request

Observed memory leak in ssl library: Python 3.14 GC issue #142516

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.