GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-90985: Revert "Deprecate passing a message into cancel()" (GH-97999) by miss-islington · Pull Request #98006 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 7, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum [email protected]

  • Issue: Confusing CancelError message if multiple cancellations are scheduled #90985

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum @miss-islington
pythonGH-90985: Revert "Deprecate passing a message into cancel()" (p…
0519adc 
…ythonGH-97999)

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners October 7, 2022 00:30
@bedevere-bot bedevere-bot added the awaiting review label Oct 7, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 7, 2022
GH-90985: Revert "Deprecate passing a message into cancel()" #97999
Merged
gvanrossum
gvanrossum approved these changes Oct 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 7, 2022
@gvanrossum

gvanrossum commented Oct 7, 2022

Copy link
Copy Markdown
Member

@pablogsal Can this land in 3.11.0 please?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington
miss-islington merged commit d163d59 into python:3.11 Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
@miss-islington
miss-islington deleted the backport-09de8d7-3.11 branch October 7, 2022 01:50
@gvanrossum gvanrossum mentioned this pull request Oct 15, 2022
Occasional incorrect chaining of CancelledError when calling 'cancel' on result of 'asyncio.gather' #97907
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @gvanrossum @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.