GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-90985: Revert "Deprecate passing a message into cancel()" by gvanrossum · Pull Request #97999 · python/cpython

Conversation

@gvanrossum

@gvanrossum gvanrossum commented Oct 6, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.

  • Issue: Confusing CancelError message if multiple cancellations are scheduled #90985

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@gvanrossum
Revert bpo-46829: Deprecate passing a message into cancel()
a580e0d 
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
@gvanrossum
gvanrossum requested review from 1st1 and asvetlov as code owners October 6, 2022 23:01
@bedevere-bot bedevere-bot added the awaiting core review label Oct 6, 2022
@blurb-it
📜🤖 Added by blurb_it.
5d95962
JelleZijlstra
JelleZijlstra approved these changes Oct 7, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 7, 2022
@gvanrossum
gvanrossum merged commit 09de8d7 into python:main Oct 7, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 7, 2022
@gvanrossum gvanrossum added the needs backport to 3.11 only security fixes label Oct 7, 2022
@miss-islington

miss-islington commented Oct 7, 2022

Copy link
Copy Markdown
Contributor

Thanks @gvanrossum for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 7, 2022

Copy link
Copy Markdown

GH-98006 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 7, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 7, 2022
@gvanrossum @miss-islington
pythonGH-90985: Revert "Deprecate passing a message into cancel()" (p…
0519adc 
…ythonGH-97999)

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <[email protected]>
@gvanrossum
gvanrossum deleted the revert-cancel-msg-deprecation branch October 7, 2022 00:30
1st1
1st1 reviewed Oct 7, 2022
View reviewed changes

@1st1 1st1 left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
miss-islington added a commit that referenced this pull request Oct 7, 2022
@miss-islington @gvanrossum
GH-90985: Revert "Deprecate passing a message into cancel()" (GH-97999)
d163d59 
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 8, 2022
@carljm
Merge branch 'main' into typewatch
0de5aff 
* main:
  pythongh-86298: Ensure that __loader__ and __spec__.loader agree in warnings.warn_explicit() (pythonGH-97803)
  pythongh-82874: Convert remaining importlib format uses to f-str. (python#98005)
  Docs: Fix backtick errors found by sphinx-lint (python#97998)
  pythongh-97850: Remove deprecated functions from `importlib.utils` (python#97898)
  Remove extra spaces in custom openSSL documentation. (python#93568)
  pythonGH-90985: Revert  "Deprecate passing a message into cancel()" (python#97999)
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@gvanrossum @mpage
pythonGH-90985: Revert "Deprecate passing a message into cancel()" (p…
7eba427 
…ython#97999)

Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @gvanrossum @pablogsal
GH-90985: Revert "Deprecate passing a message into cancel()" (GH-97999)
981b509 
Reason: we were too hasty in deprecating this.
We shouldn't deprecate it before we have a replacement.
(cherry picked from commit 09de8d7)

Co-authored-by: Guido van Rossum <[email protected]>
@AA-Turner AA-Turner mentioned this pull request Sep 22, 2023
GH-109190: Copyedit 3.12 What's New: Deprecations #109766
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 1st1 left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@gvanrossum @miss-islington @bedevere-bot @1st1 @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.