GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-86404: Doc CI: Disable suspicious checks. (GH-26575) by JulienPalard · Pull Request #98221 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Oct 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

make suspicious is disabled on 3.11 and removed in main, as it has been replaced by sphinx-lint.

Keeping the CI enabled with it here may lead to false positives from make suspicious during documentation backports, leading to painfull backports.

  • Issue: Deprecate suspicious.py? #86404

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

ezio-melotti reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@JulienPalard
pythongh-86404: Doc CI: Disable suspicious checks.
30da00e
@JulienPalard
JulienPalard requested a review from ezio-melotti as a code owner October 12, 2022 15:53
@bedevere-bot bedevere-bot added the awaiting core review label Oct 12, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 12, 2022
bpo-42238: Doc CI: Disable suspicious checks. #26575
Merged
@bedevere-bot bedevere-bot added the skip news label Oct 12, 2022
@JulienPalard JulienPalard mentioned this pull request Oct 12, 2022
gh-86404: Doc: Drop now unused make suspicious and rstlint. #98179
Merged
JelleZijlstra
JelleZijlstra approved these changes Oct 12, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 12, 2022
@JulienPalard
JulienPalard merged commit a0c1152 into python:3.10 Oct 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 12, 2022
@JulienPalard
JulienPalard deleted the mdk-suspicious-3.10 branch October 12, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@JulienPalard @JelleZijlstra @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.