GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-42238: Doc CI: Disable suspicious checks. by JulienPalard · Pull Request #26575 · python/cpython

Conversation

@JulienPalard

@JulienPalard JulienPalard commented Jun 7, 2021 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They are slow and raise too many false positive, I'm in the slow
process to try to change this.

I've removed it from PEP 101 too to avoid the burden for RMs.

I've setup a cron to follow this closely / to avoid to forgot to monitor this closely.

https://bugs.python.org/issue42238

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@JulienPalard
bpo-42238: Doc CI: Disable suspicious checks.
ef53768 
They are slow and raise too many false positive, I'm in the slow
process to try to change this.
@JulienPalard JulienPalard added docs Documentation in the Doc dir skip news labels Jun 7, 2021
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Jun 7, 2021
@bedevere-bot bedevere-bot added the awaiting core review label Jun 7, 2021
vstinner
vstinner approved these changes Jun 7, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe you can document this unknown command in the devguide? For example, near:
https://devguide.python.org/documenting/#gotchas

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Jun 7, 2021
@JulienPalard
JulienPalard merged commit 227a093 into python:main Jun 8, 2021
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 8, 2021
@JulienPalard
JulienPalard deleted the mdk/drop-suspicious branch June 8, 2021 07:23
@JulienPalard

JulienPalard commented Jun 8, 2021

Copy link
Copy Markdown
Member Author

For the moment my biggest issue is: people are autonomously and quietly fixing what's reported by make suspicious, so I don't have a list of true positives to work on.

So my current idea is to let people people commit errors¹, fix them myself (I've setup a build bot to monitor this closely) to document true positives and try to implement them in make check (or in Sphinx).

1: It is not expected to happen often, and have the nice side effet of not bothering people with false positives: 9 out of 12 errors reported by make suspicious are false positives.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv ambv mentioned this pull request Nov 19, 2021
bpo-42238: [doc]: Hide false positive in make suspicious. #29636
Merged
@JulienPalard JulienPalard mentioned this pull request Apr 10, 2022
Deprecate suspicious.py? #86404
Closed
@ezio-melotti ezio-melotti mentioned this pull request Oct 12, 2022
gh-86404: Doc: Drop now unused make suspicious and rstlint. #98179
Merged
@bedevere-bot

bedevere-bot commented Oct 12, 2022

Copy link
Copy Markdown

GH-98221 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JulienPalard added a commit that referenced this pull request Oct 12, 2022
@JulienPalard
[3.10] gh-86404: Doc CI: Disable suspicious checks. (GH-26575) (GH-98221
a0c1152 
)

gh-86404: Doc CI: Disable suspicious checks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JulienPalard @bedevere-bot @vstinner @the-knights-who-say-ni
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.