GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: Cover `PyEval_GetFuncDesc` function by sobolevn · Pull Request #98300 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 15, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Снимок экрана 2022-10-15 в 23 54 22

This function is very stange. I don't understand:

  • Why it is needed
  • Why it is " object" and not "object"

Related #81826

CC @encukou
Can we deprecate it?

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-94808: Cover PyEval_GetFuncDesc function
2ed7af3
@bedevere-bot bedevere-bot added the awaiting review label Oct 15, 2022
@JelleZijlstra

JelleZijlstra commented Oct 16, 2022

Copy link
Copy Markdown
Member

Looks like it's part of the stable ABI, so for the moment we can't get rid of it. It was used in 2.7:

cpython/Python/ceval.c

Line 4499 in 8d21aa2

PyEval_GetFuncDesc(func),

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Oct 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 16, 2022
@JelleZijlstra JelleZijlstra added skip news needs backport to 3.11 only security fixes labels Oct 16, 2022
@sobolevn

sobolevn commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

so for the moment we can't get rid of it.

But, we can at least deprecate it :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Merge branch 'main' into cover-pyeval-get-function-desc
1e3f014
@encukou

encukou commented Oct 17, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It's intended to be used with PyEval_GetFuncName, so it appends () in foo() but [space]object in SomeType object. As external API, it's definitely weird.
See #81826 for deprecating them both.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mdboom mdboom mentioned this pull request Oct 19, 2022
Metabug: Improving C-level coverage #94808
Open
@sobolevn
sobolevn requested a review from iritkatriel November 5, 2022 12:22
iritkatriel
iritkatriel approved these changes Nov 5, 2022
View reviewed changes
@iritkatriel
Merge branch 'main' into cover-pyeval-get-function-desc
f5299ca
@iritkatriel iritkatriel self-assigned this Nov 5, 2022
@iritkatriel iritkatriel added the needs backport to 3.10 label Nov 5, 2022
@iritkatriel
iritkatriel merged commit b5f7111 into python:main Nov 5, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 5, 2022
@miss-islington

miss-islington commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 5, 2022

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @iritkatriel, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b5f711185bd11819566068ddf2a74a1402340e2d 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 5, 2022
@sobolevn @miss-islington
pythongh-94808: add tests covering PyEval_GetFuncDesc function (pyt…
40490c1 
…honGH-98300)

(cherry picked from commit b5f7111)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 5, 2022

Copy link
Copy Markdown

GH-99126 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 5, 2022
miss-islington added a commit that referenced this pull request Nov 5, 2022
@miss-islington @sobolevn
gh-94808: add tests covering PyEval_GetFuncDesc function (GH-98300)
46a493e 
(cherry picked from commit b5f7111)

Co-authored-by: Nikita Sobolev <[email protected]>
@ZeroIntensity ZeroIntensity removed the needs backport to 3.10 label Feb 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@iritkatriel iritkatriel iritkatriel approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@iritkatriel iritkatriel

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@sobolevn @JelleZijlstra @encukou @miss-islington @bedevere-bot @iritkatriel @ZeroIntensity
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.