GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98331: Update bundled pip to 22.3 by pfmoore · Pull Request #98332 · python/cpython

Conversation

@pfmoore

@pfmoore pfmoore commented Oct 16, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Update bundled pip to 22.3 #98331

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@pfmoore
Update bundled pip to 22.3
1567a5e
@bedevere-bot bedevere-bot added the awaiting core review label Oct 16, 2022
@blurb-it
📜🤖 Added by blurb_it.
59849b0
@pfmoore

pfmoore commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

@pablogsal It would be good if this could be included in the Python 3.11 final release, although I appreciate it's very late notice.

I should note that the new version of pip was just released this weekend, and if there are issues we could need to follow up with a bugfix release. While I hope there won't be any issues (there are no major changes in this release) obviously I can't guarantee that. I would be pushing hard for any such bugfix release to happen before next weekend, if one were needed. I don't know whether this possibility would affect your decision about including this patch (and/or any possible bugfix release) in 3.11 final, but I thought I should make you aware 🙂

I'll set up a backport to 3.11, for inclusion in 3.11.1, regardless.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Oct 16, 2022

Copy link
Copy Markdown
Member

Thanks for checking with me! 👍

One thing that would help me evaluate the risk better is if you could walk me through what improvements or bugfixes are important to get into 11.0.0. Is there any security fix or similar?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pfmoore

pfmoore commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

There's no major changes in 22.3 that are critical. The main reason for bundling the latest version is to allow users to not have to upgrade pip immediately on installing Python or creating a venv. So it's mostly a "quality of life" improvement, in that sense. Having the bundled pip be out of date is far from unusual, but it feels off to release a new version of pip and then immediately release a Python version that has an out of date pip1.

The only security-related change is that this version of pip bundles the latest certifi, so the certificates we use are more up to date. That's arguably important, but I wouldn't over-emphasise it (after all, we don't rush pip releases every time certifi adds new certificates, so it'd be hypocritical for me to try to claim it's crucial here...)

Footnotes

  1. We are talking about trying to bring pip's release cycle better into line with Python's, but we didn't manage to make the change for this release. ↩

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pfmoore

pfmoore commented Oct 16, 2022

Copy link
Copy Markdown
Member Author

One other question, just to make sure I don't mess anything up - if I merge this and then trigger a backport to 3.11, that will go onto the 3.11 branch ready for 3.11.1, won't it - it won't affect the release branch?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

warsaw
warsaw approved these changes Oct 16, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 16, 2022
@warsaw

warsaw commented Oct 16, 2022

Copy link
Copy Markdown
Member

I went ahead and approved it, but you should also wait for @pablogsal 's approval.

pfmoore reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pfmoore

pfmoore commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

@pablogsal A gentle reminder - am I OK to merge and backport this for 3.12/3.11.1 etc?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@pablogsal

pablogsal commented Oct 18, 2022

Copy link
Copy Markdown
Member

@pablogsal A gentle reminder - am I OK to merge and backport this for 3.12/3.11.1 etc?

Apologies for the delay!

Yeah, doing the backport is ok. I am still thinking about including it in 3.11.0, but I think it makes sense.

pfmoore reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pablogsal
pablogsal approved these changes Oct 18, 2022
View reviewed changes
@pfmoore
pfmoore merged commit 9da5215 into python:main Oct 18, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 18, 2022
@pfmoore
pfmoore deleted the pip-22.3 branch October 18, 2022 14:48
@pfmoore pfmoore added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 18, 2022
@miss-islington

miss-islington commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 18, 2022

Copy link
Copy Markdown
Contributor

Thanks @pfmoore for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Oct 18, 2022

Copy link
Copy Markdown

GH-98399 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
@pfmoore @miss-islington
pythongh-98331: Update bundled pip to 22.3 (pythonGH-98332)
f40e3ec
(cherry picked from commit 9da5215)

Co-authored-by: Paul Moore <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 18, 2022

Copy link
Copy Markdown

GH-98400 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 18, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 18, 2022
@pfmoore @miss-islington
pythongh-98331: Update bundled pip to 22.3 (pythonGH-98332)
ded5d1e
(cherry picked from commit 9da5215)

Co-authored-by: Paul Moore <[email protected]>
@pfmoore

pfmoore commented Oct 18, 2022

Copy link
Copy Markdown
Member Author

I am still thinking about including it in 3.11.0, but I think it makes sense.

FWIW, we haven't had any major issues reported, so I'm (cautiously!) optimistic that we won't need a 22.3.1 bugfix release.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

pfmoore pushed a commit that referenced this pull request Oct 18, 2022
@miss-islington
[3.10] gh-98331: Update bundled pip to 22.3 (GH-98332) (gh-98399)
676cdea
pfmoore pushed a commit that referenced this pull request Oct 18, 2022
@miss-islington
[3.11] gh-98331: Update bundled pip to 22.3 (GH-98332) (gh-98400)
651a730
pablogsal pushed a commit that referenced this pull request Oct 22, 2022
@miss-islington @pablogsal
[3.11] gh-98331: Update bundled pip to 22.3 (GH-98332) (gh-98400)
c954335
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@warsaw warsaw warsaw approved these changes
@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@pfmoore @pablogsal @warsaw @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.