GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||
GeezerVison is showing github.com — gh-93453: No longer create an event loop in get_event_loop() by serhiy-storchaka · Pull Request #98440 · python/cpython Conversation
|
|
👍🏼 to this approach. It would allow us to use the following pattern in Similarly, in motor (an |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| .. deprecated:: 3.10 | ||
| Deprecation warning is emitted if there is no running event loop. | ||
| In future Python releases, this function will be an alias of | ||
| :func:`get_running_loop`. | ||
|
|
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we should add a note telling user that in 3.10 and 3.11 (at least up to a certain patch level) this situation would emit a warning.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@serhiy-storchaka Do you want to undraft this? Then we can do a final review and merge it. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Looks great -- you can merge now! I won't insist on waiting for Yury.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I do not know the original purpose of the deprecation, so I am not sure that it is the right way. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please add a what's new entry for this.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Ah, yes, it was a reason why this PR was a draft. Thank you for a reminder. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Users were getting confused by the meaning of Then we heard from users who did understand the mechanism and were using it to solve an issue they couldn't easily solve in any other way, and we changed our mind. The current idea is that The PR implements that, AFAICT. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thank you. I know about problems with creating a new loop in |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I am planning to merge this PR only after creating a PR for 3.11 to undeprecate what was incorrectly deprecated. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
See #99949. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
NOTE: this PR assumes the fix backports will be landed in time for 3.10.9 and 3.11.1. This is currently in question (see GH-99949) so please monitor the 3.10 and 3.11 PRs before landing this one. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM. But yeah, let's wait until the 3.11/3.10 PRs have landed.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ction (#256) The sync check_connection entrypoints in the Mir and Vnc platforms called asyncio.get_event_loop() to obtain (or implicitly create) an event loop. Since CPython PR python/cpython#98440 (Python 3.12), that call no longer auto-creates a loop once anything in the process has touched the loop policy and raises RuntimeError instead. With the recent pytest-asyncio 1.x and pytest 9 bumps, xdist workers no longer incidentally have a loop pre-installed.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.