GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98374: Suppress ImportError for invalid query for help() command. by corona10 · Pull Request #98450 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Oct 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Python3.11: invalid help query raises an ImportError #98374

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@corona10
pythongh-98374: Suppress ImportError for invalid query for help() com…
a4d5b80
…mand.
@corona10
corona10 marked this pull request as ready for review October 19, 2022 14:54
@bedevere-bot bedevere-bot added the awaiting core review label Oct 19, 2022
@corona10
corona10 requested review from ambv and iritkatriel October 19, 2022 14:54
@corona10 corona10 added the needs backport to 3.11 only security fixes label Oct 19, 2022
arhadthedev
arhadthedev reviewed Oct 19, 2022
View reviewed changes
Comment thread Lib/pydoc.py Resolved

Uh oh!

There was an error while loading. Please reload this page.

@corona10
Address code review
f9619ba
@corona10
corona10 requested a review from arhadthedev October 19, 2022 23:04
JelleZijlstra
JelleZijlstra approved these changes Oct 20, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 20, 2022
@corona10
corona10 merged commit 4156b2f into python:main Oct 20, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 20, 2022
@miss-islington

miss-islington commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Thanks @corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Oct 20, 2022

Copy link
Copy Markdown
Contributor

Sorry @corona10, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 4156b2fc1378531bdd9459cd131fb9fa25a5af34 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned corona10 Oct 20, 2022
@corona10 corona10 mentioned this pull request Oct 20, 2022
[3.11] gh-98374: Suppress ImportError for invalid query for help() co… #98472
Merged
@bedevere-bot

bedevere-bot commented Oct 20, 2022

Copy link
Copy Markdown

GH-98472 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 20, 2022
corona10 added a commit to corona10/cpython that referenced this pull request Oct 20, 2022
@corona10
[3.11] pythongh-98374: Suppress ImportError for invalid query for hel…
697e1fc
…p() command. (pythongh-98450)

(cherry picked from commit 4156b2f)

Co-authored-by: Dong-hee Na <[email protected]>
carljm added a commit to carljm/cpython that referenced this pull request Oct 20, 2022
@carljm
Merge branch 'main' into typewatch
8bba5da
* main: (40 commits)
  pythongh-98461: Fix source location in comprehensions bytecode (pythonGH-98464)
  pythongh-98421: Clean Up PyObject_Print (pythonGH-98422)
  pythongh-98360: multiprocessing now spawns children on Windows with correct argv[0] in virtual environments (pythonGH-98462)
  CODEOWNERS: Become a typing code owner (python#98480)
  [doc] Improve logging cookbook example. (pythonGH-98481)
  Add more tkinter.Canvas tests (pythonGH-98475)
  pythongh-95023: Added os.setns and os.unshare functions (python#95046)
  pythonGH-98363: Presize the list for batched() (pythonGH-98419)
  pythongh-98374: Suppress ImportError for invalid query for help() command. (pythongh-98450)
  typing tests: `_overload_dummy` raises `NotImplementedError`, not `RuntimeError` (python#98351)
  pythongh-98354: Add unicode check for 'name' attribute in _imp_create_builtin (pythonGH-98412)
  pythongh-98257: Make _PyEval_SetTrace() reentrant (python#98258)
  pythongh-98414: py.exe launcher does not use defaults for -V:company/ option (pythonGH-98460)
  pythongh-98417: Store int_max_str_digits on the Interpreter State (pythonGH-98418)
  Doc: Remove title text from internal links (python#98409)
  [doc] Refresh the venv introduction documentation, and correct the statement about VIRTUAL_ENV (pythonGH-98350)
  Docs: Bump sphinx-lint and fix unbalanced inline literal markup (python#98441)
  pythongh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) (pythonGH-93231)
  pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `_test_multiprocessing.py` (pythonGH-93233)
  pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_py_compile.py` (pythonGH-93235)
  ...
@corona10
corona10 deleted the gh-98374 branch October 21, 2022 05:03
@terryjreedy terryjreedy mentioned this pull request Jun 12, 2023
gh-102541: Hide traceback in help prompt #102614
Merged
@terryjreedy terryjreedy mentioned this pull request Jul 2, 2023
help CLI shows a traceback when import failed #102541
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@ambv ambv Awaiting requested review from ambv
@iritkatriel iritkatriel Awaiting requested review from iritkatriel
@arhadthedev arhadthedev Awaiting requested review from arhadthedev

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @miss-islington @bedevere-bot @JelleZijlstra @arhadthedev
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.