GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
GeezerVison is showing github.com — Change links to label refs by slateny · Pull Request #98454 · python/cpython Conversation
slateny
commented
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This part doesn't render (see page) so unsure what this should look like.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a reST "comment", which doesn't render; not sure if its intended to be or not, since it does use reST syntax within itself. @encukou any insight here?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
CAM-Gerlach
reviewed
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks @slateny ; a couple comments. At least some of these are likely because things were converted from PEPs, and should be less common now that we added Intersphinx support there.
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactions
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's a reST "comment", which doesn't render; not sure if its intended to be or not, since it does use reST syntax within itself. @encukou any insight here?
Sorry, something went wrong. Uh oh!
There was an error while loading. Please reload this page. All reactionsUh oh!
There was an error while loading. Please reload this page. Uh oh!
There was an error while loading. Please reload this page. Co-authored-by: C.A.M. Gerlach <[email protected]>
| ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
There was an error while loading. Please reload this page.
|
Can't reach it with inline comments, but there are also links like here (linking to 3.4 whatsnew changelog) that I'm not too sure if it can be converted into a label. With a |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Instead of linking to a whole different docs build, what should instead be done is to tweak blurb here to add standard ref target labels for each section (and subsection) when generating the news file based on the version tag, e.g. There are a few remaining relevant instances that can be fixed in this PR: At some point, if we add pre-commit checks to this repo, we could add a check for these links, like I added for hardcoded links to PEPs and RFCs on the PEPs repo (which there also are a handful of here, BTW, and could be fixed in a separate PR). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
|
I left out for now as the pages are far too different to the corresponding modern links, and uncertain if those should be changed over or if they should just remain for historical purposes (as those pages seem to remain for historical purposes too). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yes, let's leave the old what's news unchanged as much as possible. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @slateny
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| The :mod:`tkinter.tix` module is now deprecated. :mod:`tkinter` users | ||
| should use :mod:`tkinter.ttk` instead. | ||
|
|
||
| .. _whatsnew-3.6-venv: |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sidenote: Following the convention I've used for the 3.11 What's New would be whatsnew36-venv, but I think this convention (or at least whatsnew3.6-venv) would be better—out of old habit I often avoid using . in ref target labels. In any case, no practical reason to change it here.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the confusion—I was mentioning this as a sidenote and suggestion you not change it here (instead, I really should be using it in the ref targets I'm adding, though probably too late now for 3.11—I can adopt it with 3.12). But since you have changed it, not really worth changing it again.
Just to be more clear for the future, if I'm actually requesting a change, I will pretty much always make it as a actual suggestion (unless its impractical or impossible), so you can easily apply it with Files -> Add to batch -> Commit rather than manually implementing, committing, pushing and resolving it. The way I see it is if I'm going to ask someone else to make a change on their PR (unless its really important), its only fair that I put in the work myself to implement it, so all they have to do is click a button to accept it.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
I see I see, don't worry too much about it - I checked the existing labels and just decided that it would be good to follow convention. And conversely, I requested the review so I definitely don't mind the work (and I would have to run it locally anyway just to check the rendering), but of course the ease of changing is always appreciated.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
| Add an entry for ``__module__`` in the "function" & "method" sections of the | ||
| `inspect docs types and members table | ||
| <https://docs.python.org/3/library/inspect.html#types-and-members>`_ | ||
| :ref:`inspect docs types and members table <inspect-types>`. |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Seems a bit cleaner to do
| :ref:`inspect docs types and members table <inspect-types>`. | |
| :mod:`inspect` docs :ref:`inspect-types` table. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Yeah, not much point changing those |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @slateny
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry, @slateny and @JelleZijlstra, I could not cleanly backport this to |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Sorry @slateny and @JelleZijlstra, I had trouble checking out the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@slateny would you be able to do the backports? |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Yep sure |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]> (cherry picked from commit 268129a)
|
GH-98725 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
|
GH-98726 is a backport of this pull request to the 3.10 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]> (cherry picked from commit 268129a)
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
…3.0 to version 6.4.1
Jason R. Coombs (5):
Re-use _path.build for building files.
Re-use FilesSpec from _path.
Add type hint to read_text result.
Update changelog
Update changelog
Paul Watson (1):
gh-102354: change python3 to python in docs examples (python/cpython#102696)
Stanley (1):
docs: Change links to label refs (python/cpython#98454)
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.