GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values by ethanfurman · Pull Request #98455 · python/cpython

Conversation

@ethanfurman

@ethanfurman ethanfurman commented Oct 19, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Document new 3.11 enum APIs (ReprEnum, global_* and/or show_flag_values) #98298

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ethanfurman
document ReprEnum, global_enum, and show_flag_values
2e9a6c8
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Oct 19, 2022
@ethanfurman ethanfurman removed docs Documentation in the Doc dir awaiting core review labels Oct 19, 2022
@ethanfurman
ethanfurman requested a review from CAM-Gerlach October 19, 2022 16:30
@ethanfurman

ethanfurman commented Oct 19, 2022

Copy link
Copy Markdown
Member Author

@CAM-Gerlach ReprEnum, global_enum, and show_flag_values added to documentation. Please fix any formatting issues, etc., and feel free to merge.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes docs Documentation in the Doc dir labels Oct 19, 2022
CAM-Gerlach
CAM-Gerlach reviewed Oct 19, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much @ethanfurman ! I've added some suggestions for Sphinx syntax and formatting, and a couple wording clarifications on points that confused me initially as a non-enum-expert. I can't do so myself as I'm not a core dev, but you can review and apply them with just a couple clicks under Files, click Add to Batch then Commit (or revise them with your own suggestions and apply those), and then feel free to merge, assuming I didn't make any syntax typos (there isn't a direct way for me to test them locally without committing them). Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 19, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
ethanfurman added 2 commits October 20, 2022 15:52
@ethanfurman
incorporate suggestions from CAM-Gerlach
25059f7
@ethanfurman
Merge branch 'main' into enum-whatsnew
ab04ae1
CAM-Gerlach
CAM-Gerlach reviewed Oct 21, 2022
View reviewed changes

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes for my error-causing typo, a change not applied before and one other point of confusion I noticed with my previous revision.

Also, FYI, you can avoid having to tediously apply the changes manually by just adding the suggestions to the batch under the Files tab, and then Commit-ing them in one go—I'd hate for you to waste your valuable core dev time tediously implementing my minor fixes by hand. It will also auto-resolve the respective review suggestions, getting them out of the way.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread Doc/library/enum.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman @CAM-Gerlach
Apply suggestions from code review
5fabc78
Co-authored-by: C.A.M. Gerlach <[email protected]>
@ethanfurman

ethanfurman commented Oct 21, 2022

Copy link
Copy Markdown
Member Author

@CAM-Gerlach Cool, I didn't know about the batch committing of suggestions.

CAM-Gerlach reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ethanfurman
ethanfurman requested a review from CAM-Gerlach October 21, 2022 18:59
@ethanfurman ethanfurman self-assigned this Oct 21, 2022
@ethanfurman
ethanfurman merged commit 3e95ffc into python:main Oct 21, 2022
@miss-islington

miss-islington commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2022
@ethanfurman @miss-islington
pythongh-98298: [Enum] document ReprEnum, global_enum, and show_flag_…
bcf4fca
…values (pythonGH-98455)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 3e95ffc)

Co-authored-by: Ethan Furman <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 21, 2022

Copy link
Copy Markdown

GH-98530 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 21, 2022
miss-islington added a commit that referenced this pull request Oct 21, 2022
@miss-islington @ethanfurman
gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values (…
31d23ae
…GH-98455)

Co-authored-by: C.A.M. Gerlach <[email protected]>
(cherry picked from commit 3e95ffc)

Co-authored-by: Ethan Furman <[email protected]>
@ethanfurman
ethanfurman deleted the enum-whatsnew branch November 23, 2022 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CAM-Gerlach CAM-Gerlach Awaiting requested review from CAM-Gerlach

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ethanfurman ethanfurman

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ethanfurman @miss-islington @bedevere-bot @CAM-Gerlach
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.