GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | ||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | ||||
GeezerVison is showing github.com — gh-98298: [Enum] document ReprEnum, global_enum, and show_flag_values by ethanfurman · Pull Request #98455 · python/cpython Conversation
|
|
@CAM-Gerlach |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @ethanfurman ! I've added some suggestions for Sphinx syntax and formatting, and a couple wording clarifications on points that confused me initially as a non-enum-expert. I can't do so myself as I'm not a core dev, but you can review and apply them with just a couple clicks under Files, click Add to Batch then Commit (or revise them with your own suggestions and apply those), and then feel free to merge, assuming I didn't make any syntax typos (there isn't a direct way for me to test them locally without committing them). Thanks!
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Fixes for my error-causing typo, a change not applied before and one other point of confusion I noticed with my previous revision.
Also, FYI, you can avoid having to tediously apply the changes manually by just adding the suggestions to the batch under the Files tab, and then Commit-ing them in one go—I'd hate for you to waste your valuable core dev time tediously implementing my minor fixes by hand. It will also auto-resolve the respective review suggestions, getting them out of the way.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <[email protected]>
|
@CAM-Gerlach Cool, I didn't know about the batch committing of suggestions. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @ethanfurman for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…values (pythonGH-98455) Co-authored-by: C.A.M. Gerlach <[email protected]> (cherry picked from commit 3e95ffc) Co-authored-by: Ethan Furman <[email protected]>
|
GH-98530 is a backport of this pull request to the 3.11 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…GH-98455) Co-authored-by: C.A.M. Gerlach <[email protected]> (cherry picked from commit 3e95ffc) Co-authored-by: Ethan Furman <[email protected]>
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.