GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-97928: Change the behavior of tkinter.Text.count() by serhiy-storchaka · Pull Request #98484 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It now always returns an integer if one or less counting options are specified. Previously it could return a single count as a 1-tuple, an integer (only if option "update" was specified) or None if no items found. The result is now the same if wantobjects is set to 0.

  • Issue: tkinter.Text.count(index1, index2) returns None not (0,) when index1 equals index2 #97928

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@bedevere-bot bedevere-bot added the awaiting core review label Oct 20, 2022
@serhiy-storchaka
pythongh-97928: Change the behavior of tkinter.Text.count()
de2f3e3
It now always returns an integer if one or less counting options are specified.
Previously it could return a single count as a 1-tuple, an integer (only if
option "update" was specified) or None if no items found.
The result is now the same if wantobjects is set to 0.
@serhiy-storchaka
serhiy-storchaka force-pushed the tkinter-text-count branch from 5829464 to de2f3e3 Compare October 20, 2022 14:00
@serhiy-storchaka
Fix IDLE.
9a9b237
@serhiy-storchaka

serhiy-storchaka commented Oct 28, 2022

Copy link
Copy Markdown
Member Author

It is a breaking change. It broke a code in IDLE which contained a workaround for the current behavior, but the fixed code is clearer.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
Merge branch 'main' into tkinter-text-count
171d2e8
@bedevere-app bedevere-app Bot mentioned this pull request Oct 24, 2023
tkinter.Text.count(index1, index2) returns None not (0,) when index1 equals index2 #97928
Closed
@serhiy-storchaka
Minor tweaks.
f23eed8
@serhiy-storchaka
serhiy-storchaka marked this pull request as ready for review October 24, 2023 09:05
@serhiy-storchaka
serhiy-storchaka requested a review from terryjreedy as a code owner October 24, 2023 09:05
@serhiy-storchaka
Silence Sphinx warning.
9d036a2
@serhiy-storchaka
serhiy-storchaka merged commit b8c20f9 into python:main Oct 24, 2023
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 24, 2023
@serhiy-storchaka
serhiy-storchaka deleted the tkinter-text-count branch October 24, 2023 09:59
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Feb 5, 2024
@serhiy-storchaka
pythongh-98484: Partially restore the behavior of tkinter.Text.count(…
9f6e1db
…) by default

By default, it preserves an inconsistent behavior of older Python
versions: packs the count into a 1-tuple if only one or none
options are specified (including 'update').
Except that setting wantobjects to 0 no longer affects the result.

Add a new parameter return_ints: specifying return_ints=True makes
Text.count() returning the single count as an integer.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@serhiy-storchaka @aisk
pythongh-97928: Change the behavior of tkinter.Text.count() (pythonGH…
5c8a327
…-98484)

It now always returns an integer if one or less counting options are specified.
Previously it could return a single count as a 1-tuple, an integer (only if
option "update" was specified) or None if no items found.
The result is now the same if wantobjects is set to 0.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@serhiy-storchaka @Glyphack
pythongh-97928: Change the behavior of tkinter.Text.count() (pythonGH…
e88d884
…-98484)

It now always returns an integer if one or less counting options are specified.
Previously it could return a single count as a 1-tuple, an integer (only if
option "update" was specified) or None if no items found.
The result is now the same if wantobjects is set to 0.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.