GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-98407: fix `test_kill_issue43884` to not leak child processes by kumaraditya303 · Pull Request #98491 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: AMD64 Ubuntu Shared 3.x: python processes killed with SIGKILL by Linux Out-of-Memory (OOM), maybe related to test_asyncio #98407

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners October 20, 2022 15:53
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 20, 2022
@kumaraditya303
use process group
65ed5bf
@kumaraditya303 kumaraditya303 added skip news needs backport to 3.11 only security fixes labels Oct 20, 2022
@kumaraditya303
kumaraditya303 force-pushed the pg branch from e8c9f0f to 65ed5bf Compare October 20, 2022 15:54
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022
@bedevere-bot

bedevere-bot commented Oct 20, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 65ed5bf 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 20, 2022
@gvanrossum gvanrossum mentioned this pull request Oct 20, 2022
AMD64 Ubuntu Shared 3.x: python processes killed with SIGKILL by Linux Out-of-Memory (OOM), maybe related to test_asyncio #98407
Closed
gvanrossum
gvanrossum reviewed Oct 20, 2022
View reviewed changes
Comment thread Lib/test/test_asyncio/test_subprocess.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits October 23, 2022 07:57
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into pg
40644c5
@kumaraditya303
change command
0c6cadc
@kumaraditya303 kumaraditya303 changed the title GH-98407: use process group in asyncio test_kill_issue43884 GH-98407: fix test_kill_issue43884 to not leak child processes Oct 23, 2022
@kumaraditya303
kumaraditya303 requested a review from gvanrossum October 23, 2022 17:13
gvanrossum
gvanrossum approved these changes Oct 24, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like confirmation from the OP (@db3l) that this indeed no longer leaves orphan processes hanging around (for more than 2 seconds :-).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 24, 2022
@db3l

db3l commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

@gvanrossum I can confirm that this PR built locally leaves no processes. I'll also watch for the regular buildbot run post-merge.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Oct 24, 2022
View reviewed changes
@gvanrossum
gvanrossum merged commit 3b2724a into python:main Oct 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-98407: fix test_kill_issue43884 to not leak child processes (
053dab5 
pythonGH-98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98613 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
GH-98407: fix test_kill_issue43884 to not leak child processes (GH-…
3a1eb81 
…98491)

(cherry picked from commit 3b2724a)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303
kumaraditya303 deleted the pg branch October 26, 2022 16:28
@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

I don't understand this change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

Rationale for sleep 1; sleep 1: #98407 (comment)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the topic-asyncio label Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@kumaraditya303 @bedevere-bot @db3l @miss-islington @vstinner @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.