GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98172: [doc] mention that except* handles naked exceptions by iritkatriel · Pull Request #98496 · python/cpython

Conversation

@iritkatriel

@iritkatriel iritkatriel commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Documentation for except* clause and ExceptionGroup can be improved . #98172

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel
pythongh-98172: mention that except* handles naked exceptions
ff59828
@iritkatriel iritkatriel added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels Oct 20, 2022
@iritkatriel
iritkatriel requested a review from JelleZijlstra October 20, 2022 20:19
@bedevere-bot bedevere-bot added the awaiting core review label Oct 20, 2022
@iritkatriel
iritkatriel requested a review from gvanrossum October 20, 2022 20:41
gvanrossum
gvanrossum approved these changes Oct 20, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Oct 20, 2022
JelleZijlstra
JelleZijlstra approved these changes Oct 20, 2022
View reviewed changes

@JelleZijlstra JelleZijlstra left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one optional nit

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/reference/compound_stmts.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@iritkatriel @JelleZijlstra
OSError --> BlockingIOError
2942b9d 
Co-authored-by: Jelle Zijlstra <[email protected]>
@iritkatriel
iritkatriel merged commit 8367ca1 into python:main Oct 21, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 21, 2022
@miss-islington

miss-islington commented Oct 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @iritkatriel for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 21, 2022

Copy link
Copy Markdown

GH-98514 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 21, 2022
@iritkatriel @miss-islington
pythongh-98172: [doc] mention that except* handles naked exceptions (p…
37d2e02 
…ythonGH-98496)

(cherry picked from commit 8367ca1)

Co-authored-by: Irit Katriel <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 21, 2022
miss-islington added a commit that referenced this pull request Oct 21, 2022
@miss-islington @iritkatriel
gh-98172: [doc] mention that except* handles naked exceptions (GH-98496)
0bc2cf9 
(cherry picked from commit 8367ca1)

Co-authored-by: Irit Katriel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@gvanrossum gvanrossum gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@iritkatriel @miss-islington @bedevere-bot @JelleZijlstra @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.