GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-77753: Add example for values that compare equal in stdtypes by slateny · Pull Request #98497 · python/cpython

Conversation

@slateny

@slateny slateny commented Oct 20, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

https://docs.python.org/dev/library/stdtypes.html#mapping-types-dict

  • Issue: Better document mixed-type comparison of set items, dict keys #77753

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@slateny
Add example for values that compare equal in stdtypes
8a0b80c
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 20, 2022
slateny
slateny commented Oct 20, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
slateny
slateny commented Oct 20, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@slateny
slateny requested a review from mdickinson October 20, 2022 20:59
JelleZijlstra
JelleZijlstra reviewed Oct 20, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/stdtypes.rst
@@ -4370,8 +4370,8 @@ type, the :dfn:`dictionary`. (For other containers see the built-in
A dictionary's keys are *almost* arbitrary values. Values that are not

@JelleZijlstra JelleZijlstra Oct 20, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like this "almost arbitrary values" wording, since several very common types (lists, dicts, sets) can't be used as dict keys. No need to change that in this PR though.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
slateny reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@slateny @JelleZijlstra
Rephrase succinctly
b95d14d 
Co-authored-by: Jelle Zijlstra <[email protected]>
slateny
slateny commented Oct 21, 2022
View reviewed changes
Comment thread Doc/library/stdtypes.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@slateny
Remove floating-point note
f992fd5
JelleZijlstra
JelleZijlstra approved these changes Oct 26, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 26, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 26, 2022
@JelleZijlstra
JelleZijlstra merged commit 0ca6a4d into python:main Oct 26, 2022
@miss-islington

miss-islington commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @slateny for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 26, 2022
@bedevere-bot

bedevere-bot commented Oct 26, 2022

Copy link
Copy Markdown

GH-98693 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
@bedevere-bot

bedevere-bot commented Oct 26, 2022

Copy link
Copy Markdown

GH-98694 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@slateny @miss-islington
pythongh-77753: Add example for values that compare equal in stdtypes (…
02a632f 
…pythonGH-98497)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 0ca6a4d)

Co-authored-by: Stanley <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@slateny @miss-islington
pythongh-77753: Add example for values that compare equal in stdtypes (…
c1ff611 
…pythonGH-98497)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 0ca6a4d)

Co-authored-by: Stanley <[email protected]>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @slateny
gh-77753: Add example for values that compare equal in stdtypes (GH-9…
0f93725 
…8497)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 0ca6a4d)

Co-authored-by: Stanley <[email protected]>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @slateny
gh-77753: Add example for values that compare equal in stdtypes (GH-9…
7a25d27 
…8497)

Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit 0ca6a4d)

Co-authored-by: Stanley <[email protected]>
@slateny
slateny deleted the s/77753 branch October 26, 2022 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@mdickinson mdickinson Awaiting requested review from mdickinson

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@slateny @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.