GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-98548: Fix `-ne` shell operator spelling by sterliakov · Pull Request #98555 · python/cpython

Conversation

@sterliakov

@sterliakov sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor

gh-98548: Workflow not equal operator spelling

This shell operator should be spelled as -ne, not as -neq. All shell binary operators are two symbols long.

This bug is present on 3.10 and 3.11 branches only.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sterliakov
Fix -ne shell operator spelling
c710ecc
@sterliakov
sterliakov requested a review from ezio-melotti as a code owner October 22, 2022 19:54
@bedevere-bot bedevere-bot added the awaiting review label Oct 22, 2022
@bedevere-bot

bedevere-bot commented Oct 22, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

ghost commented Oct 22, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sterliakov sterliakov changed the title Fix -ne shell operator spelling gh-98548: Fix -ne shell operator spelling Oct 22, 2022
@sterliakov sterliakov changed the title gh-98548: Fix -ne shell operator spelling [3.10] gh-98548: Fix -ne shell operator spelling Oct 22, 2022
@sterliakov

sterliakov commented Oct 22, 2022

Copy link
Copy Markdown
Contributor Author

Unfortunately, I cannot add "skip news" label manually, and I doubt that CI typo fix is worth an entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sterliakov sterliakov mentioned this pull request Oct 22, 2022
[3.11] gh-98548: Fix -ne shell operator spelling #98556
Merged
@hauntsaninja hauntsaninja added the skip news label Oct 23, 2022
@hauntsaninja

hauntsaninja commented Oct 23, 2022

Copy link
Copy Markdown
Contributor

Thanks for this! Let's discuss on the 3.11 PR: #98556 (review)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sterliakov
Mind set -e in github actions scripts
cc29c8d
hauntsaninja
hauntsaninja approved these changes Oct 25, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Oct 25, 2022
@JelleZijlstra JelleZijlstra self-assigned this Oct 26, 2022
@ambv
ambv merged commit db1c3d6 into python:3.10 Oct 28, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninja hauntsaninja hauntsaninja approved these changes
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sterliakov @bedevere-bot @hauntsaninja @ambv @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.