GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew by CAM-Gerlach · Pull Request #98583 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 24, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #95913

This PR copyedits, sorts and fixes the syntax of the Pending Removal section of the What's New in Python 3.11 document. In particular, it:

  • Fixes several items that had typos, were duplicated, or otherwise broken
  • Structures the list by modules, then APIs within modules, sorted alphabetically
  • De-resolves references to undocumented APIs to avoid inefficiency and warnings

It also adds several missing modules pending removal in 3.12 but not previously listed, specifically:

  • asynchat
  • asyncore
  • imp
  • The typing.io namespace
  • The typing.re namespace
  • Numerous deprecated aliases (assert* and fail*) in the unittest module that were bumped from 3.11 to 3.12 in beta 1, but not listed anywhere in the document
  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CAM-Gerlach added 2 commits October 23, 2022 23:27
@CAM-Gerlach
Fix names/references of pending removal APIs
1d30270
@CAM-Gerlach
Sort list of APIs pending removal alphabetically
518bfd2
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 24, 2022
@CAM-Gerlach
CAM-Gerlach requested review from JelleZijlstra, ezio-melotti and pablogsal October 24, 2022 04:37
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 24, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
@CAM-Gerlach
Add missing modules/submodules pending removal in 3.12
3f17a8e
@CAM-Gerlach
CAM-Gerlach force-pushed the whatsnew-edit-pending-removal branch from 974596e to 3f17a8e Compare October 24, 2022 06:38
@pablogsal pablogsal changed the title gh-95913: Fix, sort & expand Pending Rm sect in 3.11 WhatsNew gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew Oct 24, 2022
@pablogsal

pablogsal commented Oct 24, 2022

Copy link
Copy Markdown
Member

The docs are failing due to:

WARNING: undefined label: deprecated-aliases
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Merge branch 'main' into whatsnew-edit-pending-removal
169c831
encukou
encukou reviewed Oct 24, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Outdated

* :func:`!sqlite3.enable_shared_cache`
* :func:`!sqlite3.OptimizedUnicode`
* :mod:`unittest` ``fail*`` and ``assert*`` :ref:`deprecated-aliases`

@encukou encukou Oct 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* :mod:`unittest` ``fail*`` and ``assert*`` :ref:`deprecated-aliases`
* :mod:`unittest` ``fail*`` and ``assert*`` deprecated-aliases

The section was removed in GH-92556.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@JelleZijlstra JelleZijlstra Oct 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate because the line is hard to understand without links. As I understand it doesn't refer to all assert* method, just old aliases like assertEquals. Maybe we'll have to list the methods explicitly here?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@encukou encukou Oct 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. IMO the removed table should have been moved here. I'll make a commit.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

@encukou encukou Oct 24, 2022

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed directly to CAM's branch, as it would have been awkward as a suggestion or PR-for-a-PR

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@CAM-Gerlach CAM-Gerlach Oct 24, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the help and sorry for not being around; I was getting a few hours of sleep after staying at the office way too late past 4 am working on these.

Yeah, the table was removed but in 3.12 and still present in 3.11 where it mattered; my plan was to write the What's New against what would work in 3.11, and then go back later and fix the missing stuff for 3.12+, but I mistakenly thought the undefined label warning was due to -n rather than on by default (and an error with -W). In that case, just adding the full table was the best thing to do given the circumstances.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Add table of unittest deprecated aliases to 3.11 What's New
79cead2
JelleZijlstra
JelleZijlstra reviewed Oct 24, 2022
View reviewed changes
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.11.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou @JelleZijlstra
Update Doc/whatsnew/3.11.rst
5090fb8 
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
JelleZijlstra approved these changes Oct 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 24, 2022
@encukou
encukou merged commit e19c2b9 into python:main Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Fix, sort & expand pending removal sect in 3.11 Whats…
6ecd75e 
…New (pythonGH-98583)

* Fix names/references of pending removal APIs

* Sort list of APIs pending removal alphabetically

* Add missing modules/submodules pending removal in 3.12

* Add table of unittest deprecated aliases to 3.11 What's New

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
(cherry picked from commit e19c2b9)

Co-authored-by: C.A.M. Gerlach <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98600 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @CAM-Gerlach
gh-95913: Fix, sort & expand pending removal sect in 3.11 WhatsNew (G…
08c3c91 
…H-98583)

* Fix names/references of pending removal APIs

* Sort list of APIs pending removal alphabetically

* Add missing modules/submodules pending removal in 3.12

* Add table of unittest deprecated aliases to 3.11 What's New

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
(cherry picked from commit e19c2b9)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@CAM-Gerlach @pablogsal @miss-islington @bedevere-bot @encukou @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.