GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: Edit, sort & expand 3.11 WhatsNew Porting section by CAM-Gerlach · Pull Request #98585 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 24, 2022

Copy link
Copy Markdown
Member

Part of #95913

This PR copyedits, sorts and fixes the syntax of the Porting section of the What's New in Python 3.11 document. In particular, it:

  • Orders the list alphabetically by module, with builtins at the top
  • Adds, fixes and refines Sphinx cross references
  • Adds appropriate Sphinx roles and other constructs
  • Tweaks the text to fix grammar/wording issues
  • Uses consistent, direct phrasing for easier/quicker readability

One item was added with this PR, based on grepping the docs, and one was removed:

  • The random parameter to random.shuffle being removed was added
  • A C API change mistakenly included in this section was removed, and will be added to the Porting section of the C API in a followup PR

There are likely a number of others that could be found by scouring the docs and changelog in detail, but I decided it was most pragmatic to defer that at least until later.

  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CAM-Gerlach added 4 commits October 24, 2022 02:09
@CAM-Gerlach
Fix/improve Sphinx syntax and grammar/phrasing for Porting items
6069534
@CAM-Gerlach
Sort items by module alphabetically, with builtins at the top
0860760
@CAM-Gerlach
Remove out of place C API change added to Python Porting section
c1ae7cb
@CAM-Gerlach
Add random.shuffle random parameter change to Porting section
fb9b90b
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 24, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 24, 2022
@CAM-Gerlach
CAM-Gerlach requested review from JelleZijlstra, ezio-melotti and pablogsal October 24, 2022 07:26
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 24, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
@pablogsal
pablogsal merged commit 43bef54 into python:main Oct 24, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Edit, sort & expand 3.11 WhatsNew Porting section (py…
2c4d6e6 
…thonGH-98585)

(cherry picked from commit 43bef54)

Co-authored-by: C.A.M. Gerlach <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98595 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @CAM-Gerlach
gh-95913: Edit, sort & expand 3.11 WhatsNew Porting section (GH-98585)
1beab50 
(cherry picked from commit 43bef54)

Co-authored-by: C.A.M. Gerlach <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @CAM-Gerlach @pablogsal
gh-95913: Edit, sort & expand 3.11 WhatsNew Porting section (GH-98585)
cda8026 
(cherry picked from commit 43bef54)

Co-authored-by: C.A.M. Gerlach <[email protected]>
pablogsal pushed a commit that referenced this pull request Oct 24, 2022
@miss-islington @CAM-Gerlach @pablogsal
gh-95913: Edit, sort & expand 3.11 WhatsNew Porting section (GH-98585)
cde4cf9 
(cherry picked from commit 43bef54)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@CAM-Gerlach @miss-islington @bedevere-bot @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.