GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-95913: Edit, link and sort 3.11 WhatsNew Build section by CAM-Gerlach · Pull Request #98588 · python/cpython

Conversation

CAM-Gerlach commented Oct 24, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Part of #95913

This PR copyedits, sorts and fixes/improves the syntax, cross references and links of the Build section of the What's New in Python 3.11 document. In particular, it:

Orders the list of items more sensitively to group similar/related topics together, e.g. new build requirements, new configure flags, etc.
Consolidates several items that contained mostly redundant/closely related information
Adds, fixes and refines Sphinx cross references and links to external references as appropriate
Adds appropriate Sphinx roles and other constructs
Tweaks the text to fix grammar/wording issues
Uses consistent, direct phrasing for easier/quicker readability

While I did read through the various Build changes in the changelog, and quite a few appeared to be of a similar magnitude to those added here, given this is not an area of my expertise and it would substantially delay the review of this PR, I elected to defer that until later.

Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

CAM-Gerlach added 2 commits

October 24, 2022 03:15


          Fix and improve Sphinx syntax & grammar/phrasing in Build section

be26e05


          Organize Build section by topic and consolidate duplicative entries

8dd1575

bedevere-bot added awaiting review docs

Documentation in the Doc dir

skip news labels

Oct 24, 2022

CAM-Gerlach added build

The build process and cross-build

3.11

only security fixes

needs backport to 3.11 only security fixes labels

Oct 24, 2022

CAM-Gerlach requested review from JelleZijlstra, ezio-melotti, pablogsal, tiran and vstinner and removed request for JelleZijlstra

October 24, 2022 08:43

CAM-Gerlach mentioned this pull request

Oct 24, 2022

Edit What's New for Python 3.11 #95913

Closed

31 of 33 tasks

pablogsal merged commit e81fad6 into python:main

Oct 24, 2022

miss-islington commented Oct 24, 2022

Copy link

Copy Markdown

Contributor

Thanks @CAM-Gerlach for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting review label

Oct 24, 2022

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Oct 24, 2022


          pythongh-95913: Edit, link and sort 3.11 WhatsNew Build section (pyth…

a1bae33

…onGH-98588)

(cherry picked from commit e81fad6)

Co-authored-by: C.A.M. Gerlach <[email protected]>

bedevere-bot commented Oct 24, 2022

Copy link

Copy Markdown

GH-98596 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Oct 24, 2022

miss-islington added a commit that referenced this pull request

Oct 24, 2022


          gh-95913: Edit, link and sort 3.11 WhatsNew Build section (GH-98588)

3e41c16

(cherry picked from commit e81fad6)

Co-authored-by: C.A.M. Gerlach <[email protected]>

encukou reviewed

Oct 24, 2022

View reviewed changes

Comment thread

Doc/whatsnew/3.11.rst

Comment on lines +1835 to +1858

		* Building Python now requires:

		* A `C11 <https://en.cppreference.com/w/c/11>`_ compiler.
		`Optional C11 features
		<https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Optional_features>`_
		are not required.
		(Contributed by Victor Stinner in :issue:`46656`.)

		* Support for `IEEE 754 <https://en.wikipedia.org/wiki/IEEE_754>`_
		floating point numbers.
		(Contributed by Victor Stinner in :issue:`46917`.)

		* Support for `floating point Not-a-Number (NaN)
		<https://en.wikipedia.org/wiki/NaN#Floating_point>`_,
		as the :c:macro:`!Py_NO_NAN` macro has been removed.
		(Contributed by Victor Stinner in :issue:`46656`.)

		* A `C99 <https://en.cppreference.com/w/c/99>`_
		``<math.h>`` header file providing the
		:c:func:`!copysign`, :c:func:`!hypot`, :c:func:`!isfinite`,
		:c:func:`!isinf`, :c:func:`!isnan`, and :c:func:`!round` functions
		(contributed by Victor Stinner in :issue:`45440`);
		and a :c:data:`!NAN` constant or the :c:func:`!__builtin_nan` function
		(Contributed by Victor Stinner in :issue:`46640`).

encukou Oct 24, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NaNs are part of IEEE 754, and the math functions are part of C11, so mentioning the earlier changes are redundant now.
This is specific to CPython.

Suggested change

	* Building Python now requires:

	* A `C11 <https://en.cppreference.com/w/c/11>`_ compiler.
	`Optional C11 features
	<https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Optional_features>`_
	are not required.
	(Contributed by Victor Stinner in :issue:`46656`.)

	* Support for `IEEE 754 <https://en.wikipedia.org/wiki/IEEE_754>`_
	floating point numbers.
	(Contributed by Victor Stinner in :issue:`46917`.)

	* Support for `floating point Not-a-Number (NaN)
	<https://en.wikipedia.org/wiki/NaN#Floating_point>`_,
	as the :c:macro:`!Py_NO_NAN` macro has been removed.
	(Contributed by Victor Stinner in :issue:`46656`.)

	* A `C99 <https://en.cppreference.com/w/c/99>`_
	``<math.h>`` header file providing the
	:c:func:`!copysign`, :c:func:`!hypot`, :c:func:`!isfinite`,
	:c:func:`!isinf`, :c:func:`!isnan`, and :c:func:`!round` functions
	(contributed by Victor Stinner in :issue:`45440`);
	and a :c:data:`!NAN` constant or the :c:func:`!__builtin_nan` function
	(Contributed by Victor Stinner in :issue:`46640`).
	* Building CPython now requires:

	* A `C11 <https://en.cppreference.com/w/c/11>`_ compiler and standard library.
	`Optional C11 features
	<https://en.wikipedia.org/wiki/C11_(C_standard_revision)#Optional_features>`_
	are not required.
	(Contributed by Victor Stinner in :issue:`46656`,
	:issue:`45440`, :issue:`46640`.)

	* Support for `IEEE 754 <https://en.wikipedia.org/wiki/IEEE_754>`_
	floating point numbers.
	(Contributed by Victor Stinner in :issue:`46917`.)

	* The :c:macro:`!Py_NO_NAN` macro has been removed.
	Since CPython now requires IEEE 754 floats, NaN values are always available.
	(Contributed by Victor Stinner in :issue:`46656`.)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

encukou Oct 24, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, too late. No big deal.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

CAM-Gerlach Oct 24, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that. I was wondering about it, but I wanted to be conservative with my initial changes since I wasn't 100% sure. I can submit a PR for you (with you co-authored on the commit) to apply it going forward, or you can if you prefer.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

encukou Oct 27, 2022

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go ahead. I might get to it later, as my task list shrinks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

CAM-Gerlach reacted with thumbs up emoji

All reactions

👍 1 reaction

CAM-Gerlach Oct 27, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, your task list actually shrinks? It seems as if by invisible dark energy that my task list is perpetually expanding...

In any case, I went ahead and opened this as PR #98781, thanks.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

pablogsal pushed a commit that referenced this pull request

Oct 24, 2022


          gh-95913: Edit, link and sort 3.11 WhatsNew Build section (GH-98588)

fdd2e15

(cherry picked from commit e81fad6)

Co-authored-by: C.A.M. Gerlach <[email protected]>

pablogsal pushed a commit that referenced this pull request

Oct 24, 2022


          gh-95913: Edit, link and sort 3.11 WhatsNew Build section (GH-98588)

c184c67

(cherry picked from commit e81fad6)

Co-authored-by: C.A.M. Gerlach <[email protected]>

CAM-Gerlach mentioned this pull request

Oct 27, 2022

gh-95913: Consolidate build requirements changes in 3.11 WhatsNew #98781

Merged

Reviewers

encukou

encukou left review comments

pablogsal

Awaiting requested review from pablogsal

tiran

Awaiting requested review from tiran

vstinner

Awaiting requested review from vstinner

ezio-melotti

Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

3.11

only security fixes

build

The build process and cross-build

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

CAM-Gerlach commented Oct 24, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Oct 24, 2022

Uh oh!

bedevere-bot commented Oct 24, 2022

Uh oh!

encukou Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

encukou Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach Oct 24, 2022

Choose a reason for hiding this comment

Uh oh!

encukou Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

CAM-Gerlach Oct 27, 2022

Choose a reason for hiding this comment

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

CAM-Gerlach commented Oct 24, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.