GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] GH-89237: fix hang in proactor `subprocess.wait_closed()` (GH-98572) by miss-islington · Pull Request #98620 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 24, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya [email protected]

  • Issue: asyncio hang in subprocess wait_closed() on Windows, BrokenPipeError #89237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303 @miss-islington
pythonGH-89237: fix hang in proactor subprocess.wait_closed() (pyth…
78ca5ae 
…onGH-98572)

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners October 24, 2022 20:21
@bedevere-bot bedevere-bot added the awaiting review label Oct 24, 2022
@bedevere-bot bedevere-bot mentioned this pull request Oct 24, 2022
GH-89237: fix hang in proactor subprocess.wait_closed() #98572
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Oct 24, 2022
gvanrossum
gvanrossum approved these changes Oct 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 24, 2022
@gvanrossum
Merge branch '3.11' into backport-ad1dc3e-3.11
8f433fd
@gvanrossum

gvanrossum commented Oct 25, 2022

Copy link
Copy Markdown
Member

The Doc building tests failed. This PR doesn't do anything with docs, other than add a NEWS item. I'm merging main in the hope that there was something in the 3.11 branch that caused that failure and that's now fixed. If not, I'm going to need help figuring out why this can't be merged into 3.11. (The 3.10 backport worked fine!)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit 8950689 into python:3.11 Oct 25, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 25, 2022
@miss-islington
miss-islington deleted the backport-ad1dc3e-3.11 branch October 25, 2022 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @gvanrossum @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.