GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-89237: fix hang in proactor `subprocess.wait_closed()` by kumaraditya303 · Pull Request #98572 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Oct 23, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: asyncio hang in subprocess wait_closed() on Windows, BrokenPipeError #89237

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
fix hang
7f4962b
@bedevere-bot bedevere-bot added the awaiting review label Oct 23, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 23, 2022
asyncio hang in subprocess wait_closed() on Windows, BrokenPipeError #89237
Closed
@blurb-it
📜🤖 Added by blurb_it.
fd9cf92
@kumaraditya303 kumaraditya303 mentioned this pull request Oct 23, 2022
_ProactorBasePipeTransport.abort() after _ProactorBasePipeTransport.close() does not cancel writes #88594
Closed
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio needs backport to 3.10 needs backport to 3.11 only security fixes labels Oct 23, 2022
@kumaraditya303
kumaraditya303 marked this pull request as ready for review October 23, 2022 18:33
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov and gvanrossum as code owners October 23, 2022 18:33
@kumaraditya303
fix test and add comment
008be56
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2022
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 008be56 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 24, 2022
gvanrossum
gvanrossum reviewed Oct 24, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-10-23-18-30-39.gh-issue-89237.kBui30.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
Mention Windows in news
b1316d0
gvanrossum
gvanrossum approved these changes Oct 24, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 24, 2022
@gvanrossum
gvanrossum merged commit ad1dc3e into python:main Oct 24, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 24, 2022
@miss-islington

miss-islington commented Oct 24, 2022

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98620 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89237: fix hang in proactor subprocess.wait_closed() (pyth…
018776c 
…onGH-98572)

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot

bedevere-bot commented Oct 24, 2022

Copy link
Copy Markdown

GH-98621 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Oct 24, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89237: fix hang in proactor subprocess.wait_closed() (pyth…
78ca5ae 
…onGH-98572)

(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington added a commit that referenced this pull request Oct 24, 2022
@miss-islington @kumaraditya303
GH-89237: fix hang in proactor subprocess.wait_closed() (GH-98572)
8ba086f 
(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <[email protected]>
gvanrossum pushed a commit that referenced this pull request Oct 25, 2022
@miss-islington @kumaraditya303
[3.11] GH-89237: fix hang in proactor subprocess.wait_closed() (GH-…
8950689 
…98572) (#98620)

GH-89237: fix hang in proactor `subprocess.wait_closed()` (GH-98572)
(cherry picked from commit ad1dc3e)

Co-authored-by: Kumar Aditya <[email protected]>
@kumaraditya303
kumaraditya303 deleted the subprocess-asyncio-block branch October 25, 2022 12:22
@Fidget-Spinner Fidget-Spinner mentioned this pull request Oct 26, 2022
gh-98703: Fix asyncio proactor_events calling _call_connection_lost multiple times #98704
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @bedevere-bot @miss-islington @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.