GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-95913: Prepare Improved Modules in 3.11 WhatsNew for final edits by CAM-Gerlach · Pull Request #98631 · python/cpython

Conversation

@CAM-Gerlach

@CAM-Gerlach CAM-Gerlach commented Oct 25, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Part of #95913

I've already done the most important ones, but to ensure PRs to edit the remaining Improved Modules sections can all be submitted in parallel and don't introduce any merge conflicts with each other, this final prep PR (which can hopefully be merged quickly) ensures there are two line breaks between each section (per standard convention), and adds the same standard ref target labels to each section as the previous to enable stable cross-referencing.
This avoids both merge conflicts and cross-PR dependencies, simplifying the remaining process.

This is similar to #98342 , which did the same for the other top-level sections; I couldn't do so for these at the time since there were a number of PRs in flight on the individual module sections.

Additionally, it makes a few other small mechanical changes to make the rest go smoother:

  • Tweaked the order of the Improved Modules to fix a few out of order modules
  • Fixed a few minor formatting issues
  • Resolved the remaining Sphinx warnings in this section

Once this is merged, I can edit the remaining Improved Modules that I didn't already address before.

  • Issue: Edit What's New for Python 3.11 #95913

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
CAM-Gerlach added 4 commits October 24, 2022 21:59
@CAM-Gerlach
Add two line breaks and ref target labels to remaining subsections
beffd23
@CAM-Gerlach
Fix a few out of order Improved Modules
12321c9
@CAM-Gerlach
Fix a few minor textual formatting issues in sections
d2c059f
@CAM-Gerlach
Fix remaining Sphinx warnings in the Improved Modules section
8d0e32e
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 25, 2022
@CAM-Gerlach CAM-Gerlach changed the title Prepare Improved Modules 3.11 WhatsNew section for final edits gh-95913: Prepare Improved Modules 3.11 WhatsNew section for final edits Oct 25, 2022
@CAM-Gerlach CAM-Gerlach added 3.11 only security fixes needs backport to 3.11 only security fixes labels Oct 25, 2022
@CAM-Gerlach
CAM-Gerlach requested review from JelleZijlstra, ezio-melotti and pablogsal October 25, 2022 03:31
@CAM-Gerlach CAM-Gerlach changed the title gh-95913: Prepare Improved Modules 3.11 WhatsNew section for final edits gh-95913: Prepare Improved Modules in 3.11 WhatsNew for final edits Oct 25, 2022
@CAM-Gerlach CAM-Gerlach mentioned this pull request Oct 25, 2022
Edit What's New for Python 3.11 #95913
Closed
31 of 33 tasks
JelleZijlstra
JelleZijlstra approved these changes Oct 25, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 25, 2022
@JelleZijlstra
JelleZijlstra merged commit dd13b23 into python:main Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Sorry @CAM-Gerlach and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker dd13b23e49b8c49bc751fe5ed470773a2d60b7d1 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned JelleZijlstra Oct 25, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 25, 2022
@miss-islington

miss-islington commented Oct 25, 2022

Copy link
Copy Markdown
Contributor

Thanks @CAM-Gerlach for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Oct 25, 2022

Copy link
Copy Markdown

GH-98652 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 25, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 25, 2022
@CAM-Gerlach @miss-islington
pythongh-95913: Prepare Improved Modules in 3.11 WhatsNew for final e…
865b150 
…dits (pythonGH-98631)

* Add two line breaks and ref target labels to remaining subsections

* Fix a few out of order Improved Modules

* Fix a few minor textual formatting issues in sections

* Fix remaining Sphinx warnings in the Improved Modules section
(cherry picked from commit dd13b23)

Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Oct 25, 2022
@miss-islington @CAM-Gerlach
gh-95913: Prepare Improved Modules in 3.11 WhatsNew for final edits (G…
c96c763 
…H-98631)

* Add two line breaks and ref target labels to remaining subsections

* Fix a few out of order Improved Modules

* Fix a few minor textual formatting issues in sections

* Fix remaining Sphinx warnings in the Improved Modules section
(cherry picked from commit dd13b23)

Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

3.11 only security fixes docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@CAM-Gerlach @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.