GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98713: Use `@cpython_only` for a test that fails on PyPy by sobolevn · Pull Request #98714 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Oct 26, 2022 •
edited by miss-islington
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: typing tests: test_overload_on_compiled_functions() may not work on alternative Python implementations #98713

Automerge-Triggered-By: GH:AlexWaygood

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-98713: Use @cpython_only for a test that fails on PyPy
22a53fd
@sobolevn
sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners October 26, 2022 11:50
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 26, 2022
@sobolevn sobolevn added skip news needs backport to 3.11 only security fixes labels Oct 26, 2022
AlexWaygood
AlexWaygood reviewed Oct 26, 2022
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a short news entry? The test made it into 3.11.0.

Otherwise this looks good! You beat the PR I was writing to the finish line ;)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn reacted with laugh emoji
All reactions
  • 😄 1 reaction
@sobolevn

sobolevn commented Oct 26, 2022

Copy link
Copy Markdown
Member Author

I've never seen a NEWS entry for tests. If others say so - I surely will add it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 26, 2022

Copy link
Copy Markdown
Member

We usually skip news for PRs that improve test coverage etc, but this is fixing a bug in the test suite that existed in a previous release of Python, so I'd argue for including a short news entry.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Add news entry
8383bc2
@sobolevn sobolevn removed the skip news label Oct 26, 2022
AlexWaygood
AlexWaygood approved these changes Oct 26, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu32R.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Oct 26, 2022
@sobolevn @AlexWaygood
Update Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu3…
909a888 
…2R.rst

Co-authored-by: Alex Waygood <[email protected]>
kumaraditya303
kumaraditya303 approved these changes Oct 26, 2022
View reviewed changes
@AlexWaygood AlexWaygood added the 🤖 automerge label Oct 26, 2022
@miss-islington

miss-islington commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

@sobolevn: Status check is done, and it's a failure or timed out ❌.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood

AlexWaygood commented Oct 26, 2022

Copy link
Copy Markdown
Member

The test_asyncio failure is unrelated and will be fixed by #98704.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood merged commit 9495360 into python:main Oct 26, 2022
@miss-islington

miss-islington commented Oct 26, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Oct 26, 2022
@bedevere-bot

bedevere-bot commented Oct 26, 2022

Copy link
Copy Markdown

GH-98717 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@sobolevn @miss-islington
pythongh-98713: Use @cpython_only for a test that fails on PyPy (py…
507d211 
…thonGH-98714)

Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 9495360)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-98713: Use @cpython_only for a test that fails on PyPy (GH-98714)
ce2b56e 
Co-authored-by: Alex Waygood <[email protected]>
(cherry picked from commit 9495360)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@AlexWaygood AlexWaygood AlexWaygood approved these changes
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @AlexWaygood @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.