GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98627: Use a Switch in PyModule_FromDefAndSpec2() by ericsnowcurrently · Pull Request #98734 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Oct 26, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This helps simplify some changes in follow-up PRs. It also matches what we're doing in PyModule_ExecDef().

  • Issue: Add a Check for Extensions that Support Running in Subinterpreters #98627

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Use a switch in PyModule_FromDefAndSpec2().
11b328a
@ericsnowcurrently ericsnowcurrently added the skip news label Oct 26, 2022
@bedevere-bot bedevere-bot added the awaiting core review label Oct 26, 2022
@ericsnowcurrently
ericsnowcurrently merged commit 731909e into python:main Oct 27, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Oct 27, 2022
@ericsnowcurrently
ericsnowcurrently deleted the module-def-switch branch October 27, 2022 03:20
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Oct 28, 2022
@ericsnowcurrently @gvanrossum
pythongh-98627: Use a Switch in PyModule_FromDefAndSpec2() (pythongh-…
a64d018 
…98734)

This helps simplify some changes in follow-up PRs.  It also matches what we're doing in PyModule_ExecDef().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.