GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Clean up refleak in _io initialisation by hauntsaninja · Pull Request #98840 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Oct 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hauntsaninja
pythongh-83004: Clean up refleak in _io initialisation
8cfe833
@bedevere-bot bedevere-bot added the awaiting review label Oct 29, 2022
@hauntsaninja
hauntsaninja requested a review from brandtbucher October 29, 2022 08:14
@hauntsaninja
actually use PyModule_AddObjectRef
6087614
@hauntsaninja hauntsaninja added skip news and removed skip news labels Oct 30, 2022
@blurb-it
📜🤖 Added by blurb_it.
6eb7a9d
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Improve stdlib module initialization error handling. #83004
Closed
@hauntsaninja hauntsaninja mentioned this pull request Nov 2, 2022
gh-83004: Clean up refleak in _zoneinfo initialisation #98842
Merged
JelleZijlstra
JelleZijlstra reviewed Nov 3, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LBl79O.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-11-02-05-52-36.gh-issue-83004.LB…
de290c3
…l79O.rst
@JelleZijlstra JelleZijlstra self-assigned this Nov 3, 2022
JelleZijlstra
JelleZijlstra approved these changes Nov 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 3, 2022
@hauntsaninja
Merge branch 'main' into pythongh-83004-io
cfd6cc2
@JelleZijlstra
JelleZijlstra merged commit 1208037 into python:main Nov 3, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 3, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 3, 2022
@miss-islington

miss-islington commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington

miss-islington commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Sorry @hauntsaninja and @JelleZijlstra, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 1208037246eeab4c5c003f1651edfefb045e6fb7 3.10

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 3, 2022

Copy link
Copy Markdown

GH-99059 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 3, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 and removed needs backport to 3.10 labels Nov 3, 2022
@miss-islington

miss-islington commented Nov 3, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 3, 2022

Copy link
Copy Markdown

GH-99060 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 3, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _io initialisation (pythonGH-98840)
a106277
(cherry picked from commit 1208037)

Co-authored-by: Shantanu <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 3, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _io initialisation (pythonGH-98840)
bcaa08a
(cherry picked from commit 1208037)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Nov 3, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _io initialisation (GH-98840)
8d44f36
(cherry picked from commit 1208037)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 3, 2022

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 LTO 3.10 has failed when building commit 8d44f36.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/640/builds/941) and take a look at the build logs.
  4. Check if the failure is related to this commit (8d44f36) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/640/builds/941

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_gdb: 4 min 18 sec
  • test_urllib2net: 2 min 52 sec
  • test_multiprocessing_spawn: 2 min 33 sec
  • test_concurrent_futures: 2 min 29 sec
  • test_multiprocessing_forkserver: 2 min 9 sec
  • test_peg_generator: 1 min 52 sec
  • test_unparse: 1 min 35 sec
  • test_tokenize: 1 min 21 sec
  • test_compileall: 1 min 15 sec
  • test_venv: 1 min 15 sec

1 test altered the execution environment:
test_multiprocessing_spawn

14 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_smtpnet
test_ssl test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 5 min 44 sec

Click to see traceback logs
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.10.cstratak-RHEL7-ppc64le.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_6b1ee4c8'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.10.cstratak-RHEL7-ppc64le.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_8448b872'


Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.10.cstratak-RHEL7-ppc64le.lto/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_f70b39f7'
Warning -- Dangling processes: {<SpawnProcess name='SharedMemoryManager-313' pid=16953 parent=6541 started>}
Warning -- Dangling processes: {<SpawnProcess name='SharedMemoryManager-313' pid=16953 parent=6541 stopped exitcode=0>}
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@JelleZijlstra

JelleZijlstra commented Nov 3, 2022

Copy link
Copy Markdown
Member

That doesn't look related to this change.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _io initialisation (GH-98840)
29c3dc0
(cherry picked from commit 1208037)

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja
hauntsaninja deleted the gh-83004-io branch November 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@brandtbucher brandtbucher Awaiting requested review from brandtbucher

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hauntsaninja @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.