GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-83004: Clean up refleak in _pickle initialisation by hauntsaninja · Pull Request #98841 · python/cpython

Conversation

@hauntsaninja

@hauntsaninja hauntsaninja commented Oct 29, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Improve stdlib module initialization error handling. #83004

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hauntsaninja
pythongh-83004: Clean up refleak in _pickle initialisation
494e5b3
@bedevere-bot bedevere-bot added the awaiting review label Oct 29, 2022
hauntsaninja and others added 2 commits October 29, 2022 01:45
@hauntsaninja
actually use PyModule_AddObjectRef
9ae0e27
@blurb-it
📜🤖 Added by blurb_it.
6c21bbf
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
Improve stdlib module initialization error handling. #83004
Closed
@blurb-it
📜🤖 Added by blurb_it.
5d7cb87
@hauntsaninja hauntsaninja mentioned this pull request Nov 2, 2022
gh-83004: Clean up refleak in _zoneinfo initialisation #98842
Merged
@hauntsaninja
delete duplicate news entry
ccd82c5
JelleZijlstra
JelleZijlstra reviewed Nov 3, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-02-05-53-25.gh-issue-83004.qc_KHr.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
Update Misc/NEWS.d/next/Library/2022-11-02-05-53-25.gh-issue-83004.qc…
ae2aa96 
…_KHr.rst
@JelleZijlstra JelleZijlstra self-assigned this Nov 3, 2022
JelleZijlstra
JelleZijlstra approved these changes Nov 3, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 3, 2022
@JelleZijlstra JelleZijlstra added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 6, 2022
JelleZijlstra
JelleZijlstra approved these changes Nov 6, 2022
View reviewed changes
@JelleZijlstra
JelleZijlstra merged commit d3b82b4 into python:main Nov 6, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 6, 2022
@miss-islington

miss-islington commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _pickle initialisation (pythonGH-…
a676ed7 
…98841)

(cherry picked from commit d3b82b4)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99165 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja @miss-islington
pythongh-83004: Clean up refleak in _pickle initialisation (pythonGH-…
fca03c0 
…98841)

(cherry picked from commit d3b82b4)

Co-authored-by: Shantanu <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 6, 2022
@bedevere-bot

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99166 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 6, 2022
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _pickle initialisation (GH-98841)
5707792 
(cherry picked from commit d3b82b4)

Co-authored-by: Shantanu <[email protected]>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington @hauntsaninja
gh-83004: Clean up refleak in _pickle initialisation (GH-98841)
380b12e 
(cherry picked from commit d3b82b4)

Co-authored-by: Shantanu <[email protected]>
@hauntsaninja
hauntsaninja deleted the gh-83004-pickle branch November 21, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@hauntsaninja @miss-islington @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.