GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-98989: configure: add 3.11 to list of Pythons by JelleZijlstra · Pull Request #98988 · python/cpython

Conversation

JelleZijlstra commented Nov 2, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: configure on main branch does not look for python3.11 #98989

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          configure: add 3.11 to list of Pythons

df19225

bedevere-bot added the awaiting core review label

Nov 2, 2022

JelleZijlstra commented Nov 2, 2022

Copy link

Copy Markdown

Member Author

I'll add an issue and NEWS since the bug went out in 3.12a1 and could affect some users.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum approved these changes

Nov 2, 2022

View reviewed changes

gvanrossum left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't take my word for it, this is probably up to @tiran or @brettcannon to review.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Nov 2, 2022

JelleZijlstra changed the title ~~configure: add 3.11 to list of Pythons~~ gh-98989: configure: add 3.11 to list of Pythons

Nov 2, 2022

bedevere-bot mentioned this pull request

Nov 2, 2022

configure on main branch does not look for python3.11 #98989

Closed


          blurb

5e3677d

hauntsaninja reviewed

Nov 2, 2022

View reviewed changes

Comment thread

configure.ac


		AC_CHECK_PROGS([PYTHON_FOR_REGEN],
		[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
		[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

hauntsaninja Nov 2, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth queuing up a couple versions?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

hugovk commented Nov 2, 2022

Copy link

Copy Markdown

Member

Something to add to PEP 101 (Doing Python Releases)?

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

kumaraditya303 reviewed

Nov 2, 2022

View reviewed changes

Comment thread

configure.ac


		AC_CHECK_PROGS([PYTHON_FOR_REGEN],
		[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
		[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

kumaraditya303 Nov 2, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we allowing python3.8 and lower in the first place if we know that 3.9+ is required?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland Nov 2, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 3.9 or higher is required, we should remove the earlier and incompatible versions.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Nov 2, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guido said he wanted to remove the 3.9+ dependency that crept into one of the scripts. Increasing the minimum required version might need more discussion as it could make bootstrapping harder for some.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland reacted with thumbs up emoji

All reactions

👍 1 reaction

kumaraditya303 Nov 2, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure let's get this in first as this is failing randomly on PRs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

JelleZijlstra Nov 2, 2022

Copy link

Copy Markdown

Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland any objections to landing this?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

erlend-aasland Nov 2, 2022

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, good to good for my part :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

kumaraditya303 requested a review from erlend-aasland

November 2, 2022 10:55

erlend-aasland reviewed

Nov 2, 2022

View reviewed changes

Comment thread

Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxbdB.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

erlend-aasland self-assigned this

Nov 2, 2022


          Update Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxb…

3ca0188

…dB.rst

Co-authored-by: Erlend E. Aasland <[email protected]>

erlend-aasland approved these changes

Nov 2, 2022

View reviewed changes

JelleZijlstra mentioned this pull request

Nov 2, 2022

PEP 101: Mention that configure needs to be updated python/peps#2864

Open

JelleZijlstra commented Nov 2, 2022

Copy link

Copy Markdown

Member Author

Something to add to PEP 101 (Doing Python Releases)?

python/peps#2864

erlend-aasland and hugovk reacted with rocket emoji

All reactions

🚀 2 reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

JelleZijlstra merged commit f7241aa into python:main

Nov 2, 2022

bedevere-bot removed the awaiting merge label

Nov 2, 2022

JelleZijlstra deleted the fixconfig branch

November 2, 2022 17:05

kumaraditya303 mentioned this pull request

Nov 2, 2022

GH-90699: Remove _Py_IDENTIFIER usage from _elementtree module #99012

Merged

JelleZijlstra mentioned this pull request

Nov 2, 2022

CI: "Tests / Check if generated files are up to date" failed #99016

Closed

gvanrossum mentioned this pull request

Nov 2, 2022

Make generate_opcode_h.py compatible with Python 3.8 #99018

Closed

erlend-aasland mentioned this pull request

May 14, 2023

PYTHON_FOR_REGEN only works with Python 3.10 or newer #104487

Closed

Reviewers

hauntsaninja

hauntsaninja left review comments

erlend-aasland

erlend-aasland approved these changes

kumaraditya303

kumaraditya303 left review comments

gvanrossum

gvanrossum approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

erlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

Conversation

JelleZijlstra commented Nov 2, 2022 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelleZijlstra commented Nov 2, 2022

Uh oh!

gvanrossum left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hugovk commented Nov 2, 2022

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JelleZijlstra commented Nov 2, 2022

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

JelleZijlstra commented Nov 2, 2022 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.