GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99016: Make build scripts compatible with Python 3.8 by serhiy-storchaka · Pull Request #99017 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Nov 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: CI: "Tests / Check if generated files are up to date" failed #99016

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-99016: Make build scripts compatible with Python 3.8
2649c25
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner November 2, 2022 17:26
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
CI: "Tests / Check if generated files are up to date" failed #99016
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 2, 2022
@serhiy-storchaka serhiy-storchaka added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 2, 2022
JelleZijlstra
JelleZijlstra approved these changes Nov 2, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 2, 2022
@serhiy-storchaka
serhiy-storchaka merged commit f520d72 into python:main Nov 2, 2022
@miss-islington

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 2, 2022
@serhiy-storchaka
serhiy-storchaka deleted the python-for-regen-3.8 branch November 2, 2022 18:30
@miss-islington

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f520d720f667c87f7b70ed86ea58d73892d6b969 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Nov 2, 2022
@miss-islington

miss-islington commented Nov 2, 2022

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker f520d720f667c87f7b70ed86ea58d73892d6b969 3.10
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood AlexWaygood mentioned this pull request Nov 2, 2022
Make generate_opcode_h.py compatible with Python 3.8 #99018
Closed
@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member

Thank you, this issue started to annoy me: it prevented me to merge unrelated changes ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Nov 3, 2022

Copy link
Copy Markdown
Member Author

An unrelated failure in your PR was a cause of creating this PR.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Nov 22, 2022

Copy link
Copy Markdown

GH-99693 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 22, 2022
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Nov 22, 2022
@serhiy-storchaka
[3.11] pythongh-99016: Make build scripts compatible with Python 3.8 (p…
581e23a 
…ythonGH-99017).

(cherry picked from commit f520d72)

Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka added a commit that referenced this pull request Nov 22, 2022
@serhiy-storchaka
[3.11] gh-99016: Make build scripts compatible with Python 3.8 (GH-99017
49f2eee 
). (GH-99693)

(cherry picked from commit f520d72)
@serhiy-storchaka serhiy-storchaka removed the needs backport to 3.10 label Nov 22, 2022
@serhiy-storchaka serhiy-storchaka removed their assignment Nov 22, 2022
@erlend-aasland erlend-aasland mentioned this pull request May 14, 2023
PYTHON_FOR_REGEN only works with Python 3.10 or newer #104487
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@serhiy-storchaka @miss-islington @vstinner @bedevere-bot @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.