GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94199: Remove ssl.wrap_socket() documentation by vstinner · Pull Request #99023 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Nov 2, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The function has been removed. In the ssl documentation, replace references to the ssl.wrap_socket() function with references to the ssl.SSLContext.wrap_socket() method.

  • Issue: ssl and hashlib: Remove functions deprecated in Python 3.10 #94199

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
gh-94199: Remove ssl.wrap_socket() documentation
5e11f40 
The function has been removed. In the ssl documentation, replace
references to the ssl.wrap_socket() function with references to the
ssl.SSLContext.wrap_socket() method.
@bedevere-bot bedevere-bot mentioned this pull request Nov 2, 2022
ssl and hashlib: Remove functions deprecated in Python 3.10 #94199
Closed
@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Nov 2, 2022
@vstinner

vstinner commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

cc @illia-v
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illia-v
illia-v suggested changes Nov 2, 2022
View reviewed changes

@illia-v illia-v left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the doc!

Some arguments of ssl.wrap_socket are no longer present in SSLContext.wrap_socket.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner added 2 commits November 2, 2022 22:27
@vstinner
Fix the doc
bd07b05
@vstinner
Clarify
a0d3884
@vstinner

vstinner commented Nov 2, 2022

Copy link
Copy Markdown
Member Author

@illia-v: I updated my PR, would you mind to review it? I removed references to non-existing parameters.

I made it clear the wrap_socket() is now the only way to create SSL socket objects, as already stated in the SSLSocket documentation: https://docs.python.org/dev/library/ssl.html#ssl.SSLSocket

Instances of SSLSocket must be created using the SSLContext.wrap_socket() method.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
illia-v
illia-v suggested changes Nov 3, 2022
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/ssl.rst Outdated
Comment on lines +2053 to +2054
case, only the ``certfile`` parameter to :meth:`SSLContext.load_cert_chain`
and :func:`wrap_socket` needs to be passed. If the private key is stored
and :meth:`SSLContext.wrap_socket` needs to be passed. If the private key is stored

@illia-v illia-v Nov 3, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSLContext.wrap_socket has no certfile parameter

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
illia-v
illia-v reviewed Nov 3, 2022
View reviewed changes
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
vstinner and others added 2 commits November 3, 2022 12:33
@vstinner @illia-v
Update Doc/library/ssl.rst
e0b7e86 
Co-authored-by: Illia Volochii <[email protected]>
@vstinner @illia-v
Update Doc/library/ssl.rst
ce7a34a 
Co-authored-by: Illia Volochii <[email protected]>
illia-v
illia-v approved these changes Nov 3, 2022
View reviewed changes
@vstinner
vstinner merged commit cff1c20 into python:main Nov 3, 2022
@vstinner
vstinner deleted the ssl_doc branch November 3, 2022 12:33
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 3, 2022
@vstinner

vstinner commented Nov 3, 2022

Copy link
Copy Markdown
Member Author

Thanks @illia-v, it was more complicated than expected. Not just a simple text replace before/after ;-)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@jiridanek jiridanek mentioned this pull request Jan 2, 2024
Possible heap-use-after-free in ctypes in Python 3.12 #113576
Closed
@AA-Turner AA-Turner mentioned this pull request Jan 12, 2024
gh-104360: remove reference to removed module-level wrap_socket #104361
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@illia-v illia-v illia-v approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @illia-v @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.