GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-104360: remove reference to removed module-level wrap_socket by graingert · Pull Request #104361 · python/cpython

Conversation

graingert commented May 10, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Contributor

Issue: ssl docs still refer to removed module-level ssl.wrap_socket #104360

📚 Documentation preview 📚: https://cpython-previews--104361.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          remove reference to removed module-level wrap_socket

40aaa5a

bedevere-bot mentioned this pull request

May 10, 2023

ssl docs still refer to removed module-level ssl.wrap_socket #104360

Closed

bedevere-bot added docs

Documentation in the Doc dir

skip news labels

May 10, 2023

graingert commented

May 10, 2023

View reviewed changes

Comment thread

Doc/library/ssl.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          drive by typo fix

3c150bb

graingert marked this pull request as ready for review

May 10, 2023 14:57

bedevere-bot added the awaiting review label

May 10, 2023

eamanu reviewed

May 10, 2023

View reviewed changes

Comment thread

Doc/library/ssl.rst

		:exc:`SSLWantReadError` if it needs more data than the incoming BIO has
		available.

		- There is no module-level ``wrap_bio()`` call like there is for

eamanu May 10, 2023

Copy link

Copy Markdown

Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ssl.wrap_context() is removed, but ssl.SSLContext.wrap_socket does not.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

graingert May 10, 2023

Copy link

Copy Markdown

Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eamanu right but there is no module-level wrap_socket so this section doesn't make sense anymore

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

encukou reacted with thumbs up emoji

All reactions

👍 1 reaction

graingert requested a review from eamanu

June 2, 2023 09:57

eamanu approved these changes

Jun 17, 2023

View reviewed changes

bedevere-bot added awaiting core review and removed awaiting review labels

Jun 17, 2023


          Merge branch 'main' into remove-wrap-socket-ref

graingert requested a review from tiran

November 1, 2023 18:49

AA-Turner approved these changes

Jan 12, 2024

View reviewed changes

AA-Turner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The substantive documentation was removed in #99023.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-app Bot added awaiting merge and removed awaiting core review labels

Jan 12, 2024

AA-Turner added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jan 12, 2024

AA-Turner requested a review from encukou

January 12, 2024 23:03

encukou merged commit 127a497 into python:main

Jan 24, 2024

miss-islington-app Bot commented Jan 24, 2024

Copy link

Copy Markdown

Thanks @graingert for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting merge label

Jan 24, 2024

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 24, 2024


          pythongh-104360: remove reference to removed module-level wrap_socket (…

235d7a4

…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <[email protected]>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jan 24, 2024


          pythongh-104360: remove reference to removed module-level wrap_socket (…

4df116f

…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <[email protected]>

bedevere-app Bot commented Jan 24, 2024

Copy link

Copy Markdown

GH-114528 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Jan 24, 2024

bedevere-app Bot commented Jan 24, 2024

Copy link

Copy Markdown

GH-114529 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Jan 24, 2024

encukou pushed a commit that referenced this pull request

Jan 24, 2024


          [3.12] gh-104360: remove reference to removed module-level wrap_socket (

26f8a30

GH-104361) (GH-114528)

* remove reference to removed module-level wrap_socket
* drive by typo fix
(cherry picked from commit 127a497)

Co-authored-by: Thomas Grainger <[email protected]>

aisk pushed a commit to aisk/cpython that referenced this pull request

Feb 11, 2024


          pythongh-104360: remove reference to removed module-level wrap_socket (…

efdd16a

…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          pythongh-104360: remove reference to removed module-level wrap_socket (…

b6625a7

…pythonGH-104361)

* remove reference to removed module-level wrap_socket
* drive by typo fix

Reviewers

AA-Turner

AA-Turner approved these changes

tiran

Awaiting requested review from tiran

encukou

Awaiting requested review from encukou

+1 more reviewer

eamanu

eamanu approved these changes

Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

graingert commented May 10, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

eamanu May 10, 2023

Choose a reason for hiding this comment

Uh oh!

graingert May 10, 2023

Choose a reason for hiding this comment

Uh oh!

AA-Turner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington-app Bot commented Jan 24, 2024

Uh oh!

bedevere-app Bot commented Jan 24, 2024

Uh oh!

bedevere-app Bot commented Jan 24, 2024

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

graingert commented May 10, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.