GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-98627: Add the _testsinglephase Module by ericsnowcurrently · Pull Request #99039 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 3, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This makes it more clear that a given test is definitely testing against a single-phase init (legacy) extension module. The new module is a companion to _testmultiphase.

  • Issue: Add a Check for Extensions that Support Running in Subinterpreters #98627

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Add the _testsinglephase module.
b510374
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 3, 2022
@ericsnowcurrently
ericsnowcurrently requested a review from encukou November 3, 2022 02:33
@bedevere-bot bedevere-bot mentioned this pull request Nov 3, 2022
Add a Check for Extensions that Support Running in Subinterpreters #98627
Open
@bedevere-bot bedevere-bot added the awaiting core review label Nov 3, 2022
@ericsnowcurrently ericsnowcurrently mentioned this pull request Nov 3, 2022
gh-98627: Add an Optional Check for Extension Module Subinterpreter Compatibility #99040
Merged
@ericsnowcurrently
Build the module on Windows.
3e96618
@ericsnowcurrently
ericsnowcurrently requested a review from a team as a code owner November 3, 2022 19:37
ericsnowcurrently added 2 commits November 3, 2022 15:08
@ericsnowcurrently
Fix the case for the GUID.
c929eac
@ericsnowcurrently
Swap the project files.
a446027
@ericsnowcurrently ericsnowcurrently closed this Nov 7, 2022
@ericsnowcurrently ericsnowcurrently reopened this Nov 7, 2022
@ericsnowcurrently
ericsnowcurrently merged commit d45cc80 into python:main Nov 8, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 8, 2022
@ericsnowcurrently
ericsnowcurrently deleted the add-testsinglephase branch November 8, 2022 16:58
@ericsnowcurrently ericsnowcurrently mentioned this pull request Oct 4, 2024
Improve Testing For Importing Multiple Extension Modules From One File (and Deal With _testimportmultiple.c) #124978
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.