GeezerVison is showing github.com — gh-98627: Add an Optional Check for Extension Module Subinterpreter Compatibility by ericsnowcurrently · Pull Request #99040 · python/cpython
Conversation
Enforcing (optionally) the restriction set by PEP 489 makes sense. Furthermore, this sets the stage for a potential restriction related to a per-interpreter GIL.
This change includes the following:
- add tests for extension module subinterpreter compatibility
- add
_PyInterpreterConfig.check_multi_interp_extensions
- add
Py_RTFLAGS_MULTI_INTERP_EXTENSIONS
- add
_PyImport_CheckSubinterpIncompatibleExtensionAllowed()
- fail iff the module does not implement multi-phase init and the current interpreter is configured to check
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
vasily-v-ryabov reacted with thumbs up emoji
…_MULTI_INTERP_EXTENSIONS.
|
FYI, converting _testinternalcapi.c to multi-phase init resolves four of the test failures.
test_configured_settings (test.test_capi.test_misc.SubinterpreterTest.test_configured_settings)
The config with which an interpreter is created corresponds ... Traceback (most recent call last):
File "<string>", line 2, in <module>
ImportError: module _testinternalcapi does not support loading in subinterpreters
[...]
👇🏻
test_configured_settings (test.test_capi.test_misc.SubinterpreterTest.test_configured_settings)
The config with which an interpreter is created corresponds ... ok
[...]
|
ericsnowcurrently reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
ericsnowcurrently
added a commit
that referenced
this pull request
Feb 6, 2023
…ters (gh-101431)
The GILState API (PEP 311) implementation from 2003 made the assumption that only one thread state would ever be used for any given OS thread, explicitly disregarding the case of subinterpreters. However, PyThreadState_Swap() still facilitated switching between subinterpreters, meaning the "current" thread state (holding the GIL), and the GILState thread state could end up out of sync, causing problems (including crashes).
This change addresses the issue by keeping the two in sync in PyThreadState_Swap(). I verified the fix against gh-99040.
Note that the other GILState-subinterpreter incompatibility (with autoInterpreterState) is not resolved here.
#59956
Reviewers
encukou
Awaiting requested review from encukou
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
|