GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99275: Fix `SystemError` in `ctypes` during `__initsubclass__` by sobolevn · Pull Request #99283 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 9, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

During __initsubclass__ not all parts required by PyType_stgdict are ready.
This PR just sets a better error message, without changing the semantics of the type creation.

  • Issue: No exception set but raise SystemError when setting _fields_ of ctypes.Structure in __init_subclass__  #99275

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-99275: Fix SystemError in ctypes during __initsubclass__
19e99ea
@bedevere-bot bedevere-bot mentioned this pull request Nov 9, 2022
No exception set but raise SystemError when setting _fields_ of ctypes.Structure in __init_subclass__ #99275
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2022
@sobolevn sobolevn mentioned this pull request Nov 9, 2022
[ctypes] Do we still need _use_broken_old_ctypes_structure_semantics_? #99284
Closed
@sobolevn
sobolevn force-pushed the issue-99275 branch from 956ba13 to 19e99ea Compare November 9, 2022 09:37
gpshead
gpshead approved these changes Nov 13, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 13, 2022
@gpshead gpshead added needs backport to 3.10 needs backport to 3.11 only security fixes labels Nov 13, 2022
@gpshead
gpshead merged commit 343eb0f into python:main Nov 13, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 13, 2022
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @gpshead for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Nov 13, 2022

Copy link
Copy Markdown

GH-99447 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
@sobolevn @miss-islington
pythongh-99275: Fix SystemError in ctypes during `__initsubclass_…
16f1716 
…_` (pythonGH-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 13, 2022
@bedevere-bot

bedevere-bot commented Nov 13, 2022

Copy link
Copy Markdown

GH-99448 is a backport of this pull request to the 3.10 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
@sobolevn @miss-islington
pythongh-99275: Fix SystemError in ctypes during `__initsubclass_…
595055c 
…_` (pythonGH-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 13, 2022
miss-islington added a commit that referenced this pull request Nov 13, 2022
@miss-islington @sobolevn
gh-99275: Fix SystemError in ctypes during __initsubclass__ (GH…
14c1395 
…-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <[email protected]>
miss-islington added a commit that referenced this pull request Nov 13, 2022
@miss-islington @sobolevn
gh-99275: Fix SystemError in ctypes during __initsubclass__ (GH…
bf76d9b 
…-99283)

(cherry picked from commit 343eb0f)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @miss-islington @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.