GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-91095: Specialize calls to normal Python classes. by markshannon · Pull Request #99331 · python/cpython

Conversation

@markshannon

@markshannon markshannon commented Nov 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This is a manual rebase of #93221.

  • Issue: Specialize calls for Python classes #91095

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@markshannon
Specialize calls to normal Python classes.
cb3fd40
@markshannon
markshannon requested review from iritkatriel and methane as code owners November 10, 2022 14:19
@markshannon markshannon mentioned this pull request Nov 10, 2022
GH-91095: Specialize calls to normal python classes #93221
Closed
@markshannon markshannon closed this Nov 10, 2022
@markshannon markshannon reopened this Nov 10, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 10, 2022
Specialize calls for Python classes #91095
Closed
@markshannon
Add news
43edcd6
@brandtbucher
brandtbucher self-requested a review November 18, 2022 21:02
This was referenced Nov 18, 2022
bpo-46939: Specialize calls to Python classes #31707
Closed
bpo-46939: Specialize calls to Python classes (POSTCALL edition) #31936
Closed
markshannon added 5 commits December 12, 2022 10:26
@markshannon
Merge branch 'main' into specialize-calls-to-python-classes
a96db28
@markshannon
Merge branch 'main' into specialize-calls-to-python-classes
add2c7c
@markshannon
Fix up after merge
fbeaf9b
@markshannon
Update generated cases.
b851a2a
@markshannon
Swap order of specializations and make sure we have meaningful stats.
e46f324
@python python deleted a comment from netlify Bot Mar 10, 2023
brandtbucher
brandtbucher reviewed May 10, 2023
View reviewed changes

@brandtbucher brandtbucher left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still being considered for 3.13? I think it's one of the last big "important" cases to cover, but if it's too complex right now we can always kick the can down the road a little further...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
markshannon added 6 commits June 18, 2023 02:01
@markshannon
Merge and create static code object for init cleanup
8529037
@markshannon
Fix up new specialization to work with current interpreter generator …
dab56e5 
…and instrumentation.
@markshannon
Address review comments
4f4de5f
@markshannon
Update generated cases.
fbe0afe
@markshannon
Make structs const.
f76ab3d
@markshannon
Fix comment.
1df353e
carljm
carljm reviewed Jun 20, 2023
View reviewed changes
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Python/specialize.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@markshannon

markshannon commented Jun 21, 2023

Copy link
Copy Markdown
Member Author

Is this still being considered for 3.13?

Yes, should be ready to go now
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
carljm
carljm approved these changes Jun 21, 2023
View reviewed changes

@carljm carljm left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added the awaiting merge label Jun 21, 2023
@markshannon
markshannon merged commit 04492cb into python:main Jun 22, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Jun 22, 2023
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@markshannon @bentasker
pythonGH-91095: Specialize calls to normal Python classes. (pythonGH-…
b12f4ab 
…99331)
@markshannon
markshannon deleted the specialize-calls-to-python-classes branch September 26, 2023 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher left review comments
@carljm carljm carljm approved these changes
@iritkatriel iritkatriel Awaiting requested review from iritkatriel iritkatriel is a code owner
@methane methane Awaiting requested review from methane methane is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@markshannon @carljm @brandtbucher @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.