GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-99277: remove older version of `get_write_buffer_limits` (GH-99280) by miss-islington · Pull Request #99338 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit f1680c3)

Co-authored-by: Carlo [email protected]
Co-authored-by: Kumar Aditya [email protected]

  • Issue: Older version of get_write_buffer_limits overwrites the new implementation #99277

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@csuriano23 @kumaraditya303 @miss-islington
pythongh-99277: remove older version of get_write_buffer_limits (py…
52bace9 
…thonGH-99280)

(cherry picked from commit f1680c3)

Co-authored-by: Carlo <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners November 10, 2022 16:07
@bedevere-bot bedevere-bot mentioned this pull request Nov 10, 2022
Older version of get_write_buffer_limits overwrites the new implementation #99277
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 10, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 10, 2022
gh-99277: remove older version of get_write_buffer_limits #99280
Merged
@bedevere-bot bedevere-bot added the type-bug An unexpected behavior, bug, or error label Nov 10, 2022
kumaraditya303
kumaraditya303 approved these changes Nov 10, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 10, 2022
@kumaraditya303
kumaraditya303 requested a review from gvanrossum November 10, 2022 16:20
@gvanrossum
gvanrossum merged commit 0dfbb76 into python:3.11 Nov 10, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 10, 2022
@miss-islington
miss-islington deleted the backport-f1680c3-3.11 branch November 10, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @kumaraditya303 @gvanrossum @bedevere-bot @csuriano23
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.