GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99277: remove older version of `get_write_buffer_limits` by csuriano23 · Pull Request #99280 · python/cpython

Conversation

@csuriano23

@csuriano23 csuriano23 commented Nov 9, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Older version of get_write_buffer_limits overwrites the new implementation #99277

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Carlo Suriano
Remove older version of get_write_buffer_limits
18fbc56
@csuriano23
csuriano23 requested review from 1st1, asvetlov and gvanrossum as code owners November 9, 2022 08:12
@bedevere-bot bedevere-bot mentioned this pull request Nov 9, 2022
Older version of get_write_buffer_limits overwrites the new implementation #99277
Closed
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2022
@bedevere-bot

bedevere-bot commented Nov 9, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ghost

ghost commented Nov 9, 2022 •
edited by ghost
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
blurb-it Bot and others added 2 commits November 9, 2022 08:40
@blurb-it
📜🤖 Added by blurb_it.
5342ef7
Carlo Suriano
Fix news backticks
51d89e6
@gvanrossum gvanrossum added topic-asyncio topic-SSL labels Nov 9, 2022
@gvanrossum
gvanrossum requested a review from kumaraditya303 November 9, 2022 18:51
kumaraditya303
kumaraditya303 reviewed Nov 10, 2022
View reviewed changes
Comment thread Misc/NEWS.d/next/Library/2022-11-09-08-40-52.gh-issue-99277.J1P44O.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes type-bug An unexpected behavior, bug, or error and removed topic-SSL labels Nov 10, 2022
csuriano23 and others added 2 commits November 10, 2022 11:32
@csuriano23 @kumaraditya303
Update Misc/NEWS.d/next/Library/2022-11-09-08-40-52.gh-issue-99277.J1…
bacf372 
…P44O.rst

Co-authored-by: Kumar Aditya <[email protected]>
Carlo Suriano
Remove trailing whitespace in changelog
1230383
@csuriano23
csuriano23 force-pushed the fix-issue-99277 branch from 7d5febc to 1230383 Compare November 10, 2022 10:39
kumaraditya303
kumaraditya303 approved these changes Nov 10, 2022
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 10, 2022
@gvanrossum
gvanrossum merged commit f1680c3 into python:main Nov 10, 2022
@miss-islington

miss-islington commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @csuriano23 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
csuriano23 reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 10, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 10, 2022
@csuriano23 @kumaraditya303 @miss-islington
pythongh-99277: remove older version of get_write_buffer_limits (py…
52bace9 
…thonGH-99280)

(cherry picked from commit f1680c3)

Co-authored-by: Carlo <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 10, 2022

Copy link
Copy Markdown

GH-99338 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 10, 2022
@csuriano23
csuriano23 deleted the fix-issue-99277 branch November 10, 2022 16:31
gvanrossum pushed a commit that referenced this pull request Nov 10, 2022
@miss-islington @csuriano23 @kumaraditya303
[3.11] gh-99277: remove older version of get_write_buffer_limits (G…
0dfbb76 
…H-99280) (#99338)

(cherry picked from commit f1680c3)

Co-authored-by: Carlo <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
gvanrossum pushed a commit to gvanrossum/cpython that referenced this pull request Nov 10, 2022
@csuriano23 @kumaraditya303 @gvanrossum
pythongh-99277: remove older version of get_write_buffer_limits (py…
882fdec 
…thon#99280)

Co-authored-by: Kumar Aditya <[email protected]>
ethanfurman pushed a commit to ethanfurman/cpython that referenced this pull request Nov 12, 2022
@csuriano23 @kumaraditya303 @ethanfurman
pythongh-99277: remove older version of get_write_buffer_limits (py…
2f88446 
…thon#99280)

Co-authored-by: Kumar Aditya <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@1st1 1st1 Awaiting requested review from 1st1
@asvetlov asvetlov Awaiting requested review from asvetlov
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@csuriano23 @bedevere-bot @miss-islington @kumaraditya303 @gvanrossum
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.