GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-81057: Move the Extension Modules Cache to _PyRuntimeState by ericsnowcurrently · Pull Request #99355 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Nov 10, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

We also move the closely related max_module_number and add comments documenting the group of struct members.

  • Issue: [subinterpreters] Global C variables are a problem #81057

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 5 commits November 10, 2022 15:31
@ericsnowcurrently
Add a comment describing PyInterpreterState.modules_by_index.
e21e012
@ericsnowcurrently
Add comments describing the PyModuleDef_Base fields.
453ca0e
@ericsnowcurrently
Add _PyRuntimeState.imports.extensions.
3b93ab9
@ericsnowcurrently
Switch to _extensions_cache_*().
b3e3f45
@ericsnowcurrently
Add _PyRuntimeState.imports.last_module_index.
1663bfc
@ericsnowcurrently ericsnowcurrently added the skip news label Nov 10, 2022
@ericsnowcurrently
ericsnowcurrently requested review from brettcannon, encukou, ncoghlan and warsaw as code owners November 10, 2022 23:03
@bedevere-bot bedevere-bot mentioned this pull request Nov 10, 2022
[subinterpreters] Global C variables are a problem #81057
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 10, 2022
kumaraditya303
kumaraditya303 reviewed Nov 11, 2022
View reviewed changes
Comment thread Include/internal/pycore_import.h
#endif


struct _import_runtime_state {

@kumaraditya303 kumaraditya303 Nov 11, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also move the global import lock to runtime state?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ericsnowcurrently ericsnowcurrently Nov 11, 2022

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that's next. :)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ericsnowcurrently
Refer to the modules_by_index comment.
67dff4d
@ericsnowcurrently
ericsnowcurrently force-pushed the extensions-cache branch from 8ed0d76 to 67dff4d Compare November 11, 2022 17:22
@ericsnowcurrently
ericsnowcurrently merged commit dd36b71 into python:main Nov 11, 2022
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 11, 2022
@ericsnowcurrently
ericsnowcurrently deleted the extensions-cache branch November 11, 2022 21:16
@jackpendley jackpendley mentioned this pull request Dec 13, 2022
gh-99533: Fix issue where email.generator.Generator ignores policy when using multipart/signed #100204
Closed
@jiridanek jiridanek mentioned this pull request Jan 2, 2024
Possible heap-use-after-free in ctypes in Python 3.12 #113576
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.