GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks (GH-99414) by miss-islington · Pull Request #99424 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 13, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen [email protected]

  • Issue: Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xiaochen7 @miss-islington
pythongh-99357: Close the event loop when it is no longer used in tes…
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <[email protected]>
@miss-islington
miss-islington requested review from 1st1 and asvetlov as code owners November 13, 2022 02:59
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357
Closed
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 13, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks #99414
Merged
@bedevere-bot bedevere-bot added the skip news label Nov 13, 2022
@kumaraditya303
kumaraditya303 requested a review from gvanrossum November 13, 2022 03:02
@gvanrossum

gvanrossum commented Nov 13, 2022

Copy link
Copy Markdown
Member

I'm seeing if the Windows test failure in test_asyncgen was a fluke or repeats itself.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum

gvanrossum commented Nov 13, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out. @kumaraditya303
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303

kumaraditya303 commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Unfortunately it keeps failing on Windows, AFAICT in test_asyncio. Maybe closing the loop triggers something funky? Maybe we need to wait for certain events to occur? I guess ProactorEventLoop behaves sufficiently differently that we cannot rule this out.

See #98219, it isn't related to this PR. I am unable to reproduce on Windows 11 so maybe this only happens on Windows Server versions or slow machines.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
Merge branch '3.11' into backport-99972dc-3.11
bd12bcf
@gvanrossum

gvanrossum commented Nov 14, 2022

Copy link
Copy Markdown
Member

Sadly I cannot merge this with that test failing. I'll try running all the tests one more time, after that I'll invoke the RM.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@gvanrossum
gvanrossum merged commit 90de4b7 into python:3.11 Nov 14, 2022
@bedevere-bot bedevere-bot removed the awaiting review label Nov 14, 2022
@miss-islington
miss-islington deleted the backport-99972dc-3.11 branch November 14, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@miss-islington @gvanrossum @kumaraditya303 @bedevere-bot @xiaochen7
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.