GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-99357: Close the event loop when it is no longer used in test_uncancel_structured_blocks by xiaochen7 · Pull Request #99414 · python/cpython

Conversation

@xiaochen7

@xiaochen7 xiaochen7 commented Nov 12, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@xiaochen7
pythongh-99357: Close the event loop when it is no longer used in tes…
aaef027 
…t_uncancel_structured_blocks
@xiaochen7
xiaochen7 requested review from 1st1, asvetlov and gvanrossum as code owners November 12, 2022 17:48
@bedevere-bot bedevere-bot mentioned this pull request Nov 12, 2022
Test test_asyncio prints quite a few ResourceWarnings for "unclosed event loop" #99357
Closed
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Nov 12, 2022
@AlexWaygood AlexWaygood added topic-asyncio skip news labels Nov 12, 2022
gvanrossum
gvanrossum approved these changes Nov 12, 2022
View reviewed changes

@gvanrossum gvanrossum left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Nov 12, 2022
@gvanrossum
gvanrossum merged commit 99972dc into python:main Nov 12, 2022
@bedevere-bot bedevere-bot removed the awaiting merge label Nov 12, 2022
@gvanrossum

gvanrossum commented Nov 12, 2022

Copy link
Copy Markdown
Member

@kumaraditya303 Should we backport this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the needs backport to 3.11 only security fixes label Nov 13, 2022
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @xiaochen7 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Sorry @xiaochen7 and @gvanrossum, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 99972dc7450f1266e39202012827f4f3c995b0ca 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned gvanrossum Nov 13, 2022
@kumaraditya303 kumaraditya303 added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Nov 13, 2022
@miss-islington

miss-islington commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Thanks @xiaochen7 for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Nov 13, 2022

Copy link
Copy Markdown

GH-99424 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 13, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 13, 2022
@xiaochen7 @miss-islington
pythongh-99357: Close the event loop when it is no longer used in tes…
29f11df 
…t_uncancel_structured_blocks (pythonGH-99414)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <[email protected]>
@kumaraditya303

kumaraditya303 commented Nov 13, 2022

Copy link
Copy Markdown
Contributor

Should we backport this?

Let's backport to 3.11.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum pushed a commit that referenced this pull request Nov 14, 2022
@miss-islington @xiaochen7
[3.11] gh-99357: Close the event loop when it is no longer used in te…
90de4b7 
…st_uncancel_structured_blocks (GH-99414) (#99424)

(cherry picked from commit 99972dc)

Co-authored-by: Xiao Chen <[email protected]>
@xiaochen7
xiaochen7 deleted the close-event-loop branch November 16, 2022 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@gvanrossum gvanrossum

Labels

skip news tests Tests in the Lib/test dir topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@xiaochen7 @gvanrossum @miss-islington @bedevere-bot @kumaraditya303 @AlexWaygood
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.