GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-94808: add tests covering `PyFunction_{Get,Set}Closure` by sobolevn · Pull Request #99429 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 13, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It was like this:
Снимок экрана 2022-11-13 в 13 00 40

Now all branches are covered.

  • Issue: Metabug: Improving C-level coverage #94808

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-94808: add tests covering PyFunction_{Get,Set}Closure
efc53c1
@bedevere-bot bedevere-bot mentioned this pull request Nov 13, 2022
Metabug: Improving C-level coverage #94808
Open
@bedevere-bot bedevere-bot added the awaiting review label Nov 13, 2022
@sobolevn sobolevn added tests Tests in the Lib/test dir skip news labels Nov 13, 2022
kumaraditya303
kumaraditya303 reviewed Nov 26, 2022
View reviewed changes
Comment thread Modules/_testcapimodule.c Outdated
Comment on lines +6017 to +6018
Py_INCREF(closure);
return closure;

@kumaraditya303 kumaraditya303 Nov 26, 2022

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Py_INCREF(closure);
return closure;
return Py_NewRef(closure);

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kumaraditya303
kumaraditya303 previously requested changes Nov 26, 2022
View reviewed changes

@kumaraditya303 kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting changes and removed awaiting review labels Nov 26, 2022
@bedevere-bot

bedevere-bot commented Nov 26, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou added 3 commits March 19, 2024 15:58
@encukou
Merge in the main branch
a13d207
@encukou
Use Py_NewRef
0351162
@encukou
PEP 7 nitpick
3f738c3
@sobolevn
sobolevn requested review from gvanrossum and markshannon as code owners March 19, 2024 15:19
@encukou
encukou dismissed kumaraditya303’s stale review March 19, 2024 15:20

No more merge conflicts

@bedevere-app bedevere-app Bot added awaiting review and removed awaiting changes labels Mar 19, 2024
@encukou

encukou commented Mar 19, 2024

Copy link
Copy Markdown
Member

After a year, I took the liberty of updating to the current main branch, and fixed two nitpicks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
gvanrossum
gvanrossum approved these changes Mar 19, 2024
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Mar 19, 2024
@gvanrossum

gvanrossum commented Mar 19, 2024

Copy link
Copy Markdown
Member

Sorry about that. Go ahead and merge!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Mar 19, 2024

Copy link
Copy Markdown
Member Author

@encukou thanks a lot for your help! I forgot about this PR a long time ago :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou
encukou merged commit 8182319 into python:main Mar 20, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Mar 20, 2024
@encukou

encukou commented Mar 20, 2024

Copy link
Copy Markdown
Member

No problem, happy to help :)

Usually we backport test changes to reduce future conflicts, but since this already causes conflicts in 3.12, I'll skip the backport here.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn @vstinner
pythongh-94808: add tests covering PyFunction_{Get,Set}Closure (pyt…
8ca5a2c 
…honGH-99429)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn @adorilson
pythongh-94808: add tests covering PyFunction_{Get,Set}Closure (pyt…
1cfe1bc 
…honGH-99429)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn @diegorusso
pythongh-94808: add tests covering PyFunction_{Get,Set}Closure (pyt…
5950e82 
…honGH-99429)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@sobolevn @bedevere-bot @encukou @gvanrossum @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.