GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) by zooba · Pull Request #99493 · python/cpython

Conversation

@zooba

@zooba zooba commented Nov 14, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [doc] sys.addaudithook() documentation should be more explicit on its limitations #87604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@zooba
pythongh-87604: Avoid publishing list of active per-interpreter audit…
3a5f9f0 
… hooks via the gc module (pythonGH-99373)
@bedevere-bot bedevere-bot added the awaiting core review label Nov 14, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
[doc] sys.addaudithook() documentation should be more explicit on its limitations #87604
Closed
@zooba zooba added the needs backport to 3.8 label Nov 14, 2022
@zooba zooba changed the title gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) [3.9] gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (GH-99373) Nov 14, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 14, 2022
gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module #99373
Merged
@bedevere-bot bedevere-bot added the type-security A security issue label Nov 14, 2022
@zooba
Fix variable name
9fd2fae
@zooba

zooba commented Nov 14, 2022 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

@pablogsal We agreed (on the original PR) that this is a minor, but harmless change. I'm intending to backport it into my patchset for 3.8 and 3.9 builds at work, so figured that means it's worth backporting for everyone. But your call, of course.
pablogsal reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Nov 16, 2022

Copy link
Copy Markdown
Member

I am +1 backporting this but maybe you want to check with @ambv instead for 3.9 and 3.8?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal

pablogsal commented Nov 16, 2022

Copy link
Copy Markdown
Member

I am assuming 3.10 has the fix already no?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba

zooba commented Nov 16, 2022

Copy link
Copy Markdown
Member Author

🤦 Yes, @ambv, what are your thoughts?

It's already in 3.10 in #99492. The backport couldn't be done automatically to 3.9, which is why it's not linked yet
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

I'm +1 to backport to 3.9 and 3.8.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv
ambv merged commit 7b98207 into python:3.9 Nov 21, 2022
@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Nov 21, 2022
@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Sorry @zooba and @ambv, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 7b98207aa46bd637d07a7c4a84e998726b74acde 3.8
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ambv Nov 21, 2022
@zooba zooba added needs backport to 3.8 and removed needs backport to 3.8 labels Nov 21, 2022
@miss-islington

miss-islington commented Nov 21, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
zooba deleted the gh-87604-3.9 branch November 21, 2022 19:05
@bedevere-bot

bedevere-bot commented Nov 21, 2022

Copy link
Copy Markdown

GH-99661 is a backport of this pull request to the 3.8 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@zooba @pablogsal @ambv @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.