GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module by zooba · Pull Request #99373 · python/cpython

Conversation

@zooba

@zooba zooba commented Nov 11, 2022 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: [doc] sys.addaudithook() documentation should be more explicit on its limitations #87604

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@zooba
pythongh-87604: Avoid publishing list of active per-interpreter audit…
dd9bbf3
… hooks via the gc module
@zooba zooba added type-security A security issue needs backport to 3.8 needs backport to 3.11 only security fixes labels Nov 11, 2022
@bedevere-bot bedevere-bot mentioned this pull request Nov 11, 2022
[doc] sys.addaudithook() documentation should be more explicit on its limitations #87604
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Nov 11, 2022
gpshead
gpshead approved these changes Nov 13, 2022
View reviewed changes

@gpshead gpshead left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably of marginal value, but harrmless, it nudges the bar slightly higher. nice discussion on the issue.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Nov 13, 2022
@zooba
zooba merged commit 4e4b13e into python:main Nov 14, 2022
@miss-islington

miss-islington commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Thanks @zooba for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9, 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting merge label Nov 14, 2022
@zooba
zooba deleted the gh-87604-2 branch November 14, 2022 21:39
@bedevere-bot

bedevere-bot commented Nov 14, 2022

Copy link
Copy Markdown

GH-99491 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Nov 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2022
@zooba @miss-islington
pythongh-87604: Avoid publishing list of active per-interpreter audit…
e60ced7
… hooks via the gc module (pythonGH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
@bedevere-bot

bedevere-bot commented Nov 14, 2022

Copy link
Copy Markdown

GH-99492 is a backport of this pull request to the 3.10 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 label Nov 14, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 14, 2022
@zooba @miss-islington
pythongh-87604: Avoid publishing list of active per-interpreter audit…
d73af8e
… hooks via the gc module (pythonGH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
@miss-islington

miss-islington commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Sorry, @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 4e4b13e8f6211abbc0d53056da11357756daa314 3.9

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned zooba Nov 14, 2022
@miss-islington

miss-islington commented Nov 14, 2022

Copy link
Copy Markdown
Contributor

Sorry @zooba, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 4e4b13e8f6211abbc0d53056da11357756daa314 3.8

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot

bedevere-bot commented Nov 14, 2022

Copy link
Copy Markdown

GH-99493 is a backport of this pull request to the 3.9 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 label Nov 14, 2022
miss-islington added a commit that referenced this pull request Nov 15, 2022
@miss-islington @zooba
gh-87604: Avoid publishing list of active per-interpreter audit hooks…
e470803
… via the gc module (GH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
miss-islington added a commit that referenced this pull request Nov 15, 2022
@miss-islington @zooba
gh-87604: Avoid publishing list of active per-interpreter audit hooks…
f4cb828
… via the gc module (GH-99373)

(cherry picked from commit 4e4b13e)

Co-authored-by: Steve Dower <[email protected]>
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull request Nov 16, 2022
@CuriousLearner
Merge branch 'main' into fix-issue21914
abd206e
* main: (8272 commits)
  Update Windows readme.txt to clarify Visual Studio required versions (pythonGH-99522)
  pythongh-99460 Emscripten trampolines on optimized METH_O and METH_NOARGS code paths (python#99461)
  pythongh-92647: [Enum] use final status to determine lookup or create (pythonGH-99500)
  pythongh-81057: Move Globals in Core Code to _PyRuntimeState (pythongh-99496)
  Post 3.12.0a2
  pythongh-99300: Use Py_NewRef() in Python/Python-ast.c (python#99499)
  pythongh-93649: Split pytime and datetime tests from _testcapimodule.c (python#99494)
  pythongh-99370: fix test_zippath_from_non_installed_posix (pythonGH-99483)
  pythonGH-99205: remove `_static` field from `PyThreadState` and `PyInterpreterState` (pythonGH-99385)
  pythongh-81057: Move the Remaining Import State Globals to _PyRuntimeState (pythongh-99488)
  pythongh-87604: Avoid publishing list of active per-interpreter audit hooks via the gc module (pythonGH-99373)
  pythongh-93649: Split getargs tests from _testcapimodule.c (python#99346)
  pythongh-81057: Move Global Variables Holding Objects to _PyRuntimeState. (pythongh-99487)
  pythonGH-98219: reduce sleep time in `asyncio` subprocess test (python#99464)
  pythonGH-99388: add `loop_factory` parameter to `asyncio.run` (python#99462)
  pythongh-99300: Use Py_NewRef() in PC/ directory (python#99479)
  pythongh-99300: Use Py_NewRef() in Doc/ directory  (python#99480)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99473)
  pythongh-99300: Use Py_NewRef() in Modules/ directory (python#99469)
  pythongh-99370: Calculate zip path from prefix when in a venv (pythonGH-99371)
  ...
ambv pushed a commit that referenced this pull request Nov 21, 2022
@zooba
[3.9] gh-87604: Avoid publishing list of active per-interpreter audit…
7b98207
… hooks via the gc module (GH-99373) (GH-99493)
@bedevere-bot

bedevere-bot commented Nov 21, 2022

Copy link
Copy Markdown

GH-99661 is a backport of this pull request to the 3.8 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 label Nov 21, 2022
ambv pushed a commit that referenced this pull request Nov 21, 2022
@miss-islington @zooba
[3.8] gh-87604: Avoid publishing list of active per-interpreter audit…
b50b6f9
… hooks via the gc module (GH-99373) (GH-99661)

(cherry picked from commit 7b98207)

Co-authored-by: Steve Dower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@zooba zooba

Labels

type-security A security issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@zooba @miss-islington @bedevere-bot @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.